Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reset migration index if there is no need #2238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't reset migration index if there is no need #2238

wants to merge 1 commit into from

Conversation

komarevtsev-d
Copy link
Collaborator

No description provided.

@komarevtsev-d komarevtsev-d added large-tests Launch large tests for PR blockstore Add this label to run only cloud/blockstore build and tests on PR labels Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 305ad26.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3490 3490 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 7346af2.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3498 3498 0 0 0 0

qkrorlqr
qkrorlqr requested changes Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@qkrorlqr qkrorlqr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Нужно проверить логику в ut
  2. Стоит сравнить также DeviceUUIDs в Devices и Replicas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkrorlqr qkrorlqr qkrorlqr requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR large-tests Launch large tests for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@komarevtsev-d @qkrorlqr