issue-2074: disable IO of broken devices #2417
Open
+1,344
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharpeye
added
the
blockstore
sharpeye
force-pushed
the
users/sharpeye/issue-2074-store-suspended-io-dev-list
branch
from
669f536
to
1f988e3
Compare
sharpeye
changed the title
sharpeye
force-pushed
the
users/sharpeye/issue-2074-store-suspended-io-dev-list
branch
2 times, most recently
from
32dc4c8
to
d023386
Compare
sharpeye
force-pushed
the
users/sharpeye/issue-2074-store-suspended-io-dev-list
branch
3 times, most recently
from
379cdf6
to
de2c24a
Compare
sharpeye
force-pushed
the
users/sharpeye/issue-2074-store-suspended-io-dev-list
branch
from
de2c24a
to
18b0571
Compare
sharpeye
force-pushed
the
users/sharpeye/issue-2074-store-suspended-io-dev-list
branch
3 times, most recently
from
4d051e3
to
0b33f9a
Compare
sharpeye
force-pushed
the
users/sharpeye/issue-2074-store-suspended-io-dev-list
branch
from
0b33f9a
to
078b1ff
Compare
sharpeye
force-pushed
the
users/sharpeye/issue-2074-store-suspended-io-dev-list
branch
from
078b1ff
to
9c7b960
Compare
sharpeye
force-pushed
the
users/sharpeye/issue-2074-store-suspended-io-dev-list
branch
from
9c7b960
to
2b6bf5b
Compare
sharpeye
force-pushed
the
users/sharpeye/issue-2074-store-suspended-io-dev-list
branch
from
1e1a3b6
to
43e40ce
Compare
sharpeye
force-pushed
the
users/sharpeye/issue-2074-store-suspended-io-dev-list
branch
from
43e40ce
to
21feaa1
Compare
|
У нас же есть какие-то гарантии что RegisterAgentResponse от DR дойдет до агента? Не получится так, что агент как бы зарегался, а IO встало колом? |
Агент с DR общаются по пайпу - он гарантирует доставку, либо порвется соединение. К тому же, если девайсы засуспендились, то они были либо сломаны (DR прислал в ответе), либо поменяли серийники, и их в любом случае надо суспендить. Рабочие девайсы просто так не засуспендятся. |
komarevtsev-d
approved these changes
Nov 13, 2024
tpashkin
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2074
At startup, Disk Agent collects a list of devices with changed serial numbers and suspends such devices.
After Disk Agent registers in Disk Registry, broken devices are disabled and the rest of the devices resumed.
Disk Registry sends a list of broken devices with
TEvRegisterAgentResponse(DevicesToDisableIOfield).Suspending devices means that read/write/zero requests will receive an
E_REJECTEDerror.Disabling devices means that read/write/zero requests will receive an
E_IOerror.The list of suspended devices is stored in the
DevicesWithSuspendedIOfield in the configuration cache.