Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Disk Manager]: Fix incorrect grpc facade error reporting #2469

Merged
merged 10 commits into from
Nov 13, 2024
Merged

[Disk Manager]: Fix incorrect grpc facade error reporting #2469

merged 10 commits into from
Nov 13, 2024
+106 −1

Conversation

jkuradobery
Copy link
Collaborator

No description provided.

@jkuradobery jkuradobery changed the title [Disk Manager]: Introduce test for grpc facade error metrics [Disk Manager]: Fix incorrect grpc facade error reporting Nov 11, 2024
@SvartMetal SvartMetal added large-tests Launch large tests for PR and removed large-tests Launch large tests for PR labels Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit eb49575.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6103 6103 0 0 0 0

@jkuradobery
Copy link
Collaborator Author

jkuradobery commented Nov 13, 2024 •
edited
Loading

We will rename flags to avoid ambiguity here.
#2491

@jkuradobery jkuradobery merged commit 5dfbd00 into main Nov 13, 2024
11 of 12 checks passed
@jkuradobery jkuradobery deleted the users/jkuradobery/fix-grpc-facade-not-reporting-errors branch November 13, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gy2411 gy2411 gy2411 approved these changes

@SvartMetal SvartMetal SvartMetal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkuradobery @SvartMetal @gy2411