Sqlalchemy experiments #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valeria1235
force-pushed
the
_sqlalchemy_experiments
branch
from
2885bb2
to
83bcff3
Compare
rekby
requested changes
Feb 15, 2023
| @@ -25,6 +25,12 @@ deps = | |||
| commands = | |||
| pytest -v -m "not tls" --docker-compose-remove-volumes --docker-compose=docker-compose.yml {posargs} | |||
|
|
|||
| [testenv:py-cov] | |||
There was a problem hiding this comment.
What about add cov report to existed environments instead of create new env?
There was a problem hiding this comment.
I think it's not good to slow down tests runtime on every run (and generate some files) without clear goal to gather coverage.
| return False | ||
|
|
||
| def commit(self): | ||
| pass |
There was a problem hiding this comment.
Is it ok to pass commit?
Is is possible to use raise NotImplementError()?
There was a problem hiding this comment.
no, sqlalchemy used it implicitly and there will raises on engine.connect
Valeria1235
force-pushed
the
_sqlalchemy_experiments
branch
4 times, most recently
from
1abb285
to
3f6bdf8
Compare
Bumps [cryptography](https://github.com/pyca/cryptography) from 3.4.7 to 39.0.1. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@3.4.7...39.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [cryptography](https://github.com/pyca/cryptography) from 3.3.2 to 39.0.1. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@3.3.2...39.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Valeria1235
force-pushed
the
_sqlalchemy_experiments
branch
from
3f6bdf8
to
84ad0e2
Compare
rekby
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Support ydb dialect for sqlalchemy. Work in progress.
Pull request type
Issue Number: ydb-platform/ydb-sqlalchemy#2