Fixed Arbitrary instance for NestedBlock. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously arbitrary would only generate a LeafBlock for NestedBlock. Hence documents with NestedBlock were not really being tested at all! With this change we can see the bug reported separately in yesodweb#6.
|
Note that the Travis build is expected to fail, since this PR adds a failing test. |
creichert
added a commit
that referenced
this pull request
Jun 28, 2015
Fixed Arbitrary instance for NestedBlock.
|
Nice catch. I'm assuming this needs to be merged to test any potential fixes on #6. |
jgm
added a commit
to jgm/css-text
that referenced
this pull request
Jun 28, 2015
This allows the tests amended by yesodweb#7 and yesodweb#8 to pass again. * Simplified parsing of nested blocks. * Indefinite nesting levels are now allowed. * Some illegal CSS that was allowed by the old parser is now excluded (e.g. `@print { background: red; }`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously arbitrary would only generate a LeafBlock for NestedBlock.
Hence documents with NestedBlock were not really being tested at all!
With this change we can see the bug reported separately in #6.