-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dont merge] Fix travis build #202
Conversation
I believe this has to do with building certain test servers from source. We are testing for a bunch of different platforms (like different versions of ES and PHP) and some of them are configured to be pulled in from github. (It could also be composer-related, I'm not sure). Anyway, after a certain number of installations github asks for a key. At some point I've tried hardcoding my own key in there, and it seemed to have solved the problem, at least temporarily. |
@beowulfenator with the composer.json change I just made, the problem now seems to be an incompatibility between ES & Yii on dev-master: https://travis-ci.org/yiisoft/yii2-elasticsearch/jobs/480761513 |
There are multiple versions of PHP, multiple versions of ES and multiple versions of Yii we should test against. Is it really worth testing all of those combinations? |
If Yii is supposed to provide support for them, then the answer should be "Yes it is" I guess :) |
If it helps pin-pointing the problem, I guess we should try to fix tests for one version of PHP & one version of ES first, and then gradually introduce other combinations. I'm first trying to understand whether efforts should be put it |
Looks like the instance wasn't started or was started with non-default address. |
Also seems to be related to the ES version, check #177 (comment) Is branch 2.1 meant for what we now call Yii 3, or is it a branch aiming at targeting more recent ES versions? If it's the later, are we going to accept PRs for both |
No. 2.1 is for ES versions. See readme. |
I think it worth releasing 2.0.6 and then moving on to 2.1.0 releases. If there will be need to do 2.0.7 we can create 2.0 branch and do releases from there. |
Checked it a bit more. The problem is that master of this repository is version 2.0 and it's compatible with ES up to 4 only. Still, we're trying to run against travis's elasticsearch here. What could be done:
|
Same thing. |
#209 fixes both. |
Fix was applied to #210 |
Trying to understand why Travis builds have been failing for so long.