Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for user on exit strategy. #4757

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add support for user on exit strategy. #4757

merged 1 commit into from
Feb 5, 2025

Conversation

aee-google
Copy link
Contributor

b/385357645

yell0wd0g
yell0wd0g requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by comments (apologies if the CL wasn't ready to review!).

Can we add unittests for either or both of the classes?

cobalt/renderer/cobalt_render_frame_observer.cc Outdated Show resolved Hide resolved
cobalt/configuration/configuration.cc Outdated Show resolved Hide resolved
cobalt/configuration/configuration.cc Outdated Show resolved Hide resolved
cobalt/configuration/configuration.h Outdated Show resolved Hide resolved
@aee-google
Copy link
Contributor Author

I added a browser test. As a follow-up the browser test needs to be checked in CI.

andrewsavage1
andrewsavage1 reviewed Jan 31, 2025
View reviewed changes
cobalt/renderer/cobalt_render_frame_observer.cc Outdated Show resolved Hide resolved
cobalt/renderer/BUILD.gn Outdated Show resolved Hide resolved
@aee-google aee-google force-pushed the conceal branch 2 times, most recently from 1d23333 to 81e38a7 Compare January 31, 2025 20:08
@aee-google aee-google requested a review from a team as a code owner January 31, 2025 20:08
@aee-google aee-google force-pushed the conceal branch 3 times, most recently from 59d9c0c to 75db512 Compare January 31, 2025 23:59
yell0wd0g
yell0wd0g requested changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the browsertest!

cobalt/renderer/cobalt_render_frame_observer.h Show resolved Hide resolved
cobalt/renderer/cobalt_render_frame_observer_browsertest.cc Outdated Show resolved Hide resolved
cobalt/renderer/cobalt_render_frame_observer_browsertest.cc Outdated Show resolved Hide resolved
cobalt/configuration/configuration.h Outdated Show resolved Hide resolved
cobalt/configuration/configuration.h Show resolved Hide resolved
cobalt/renderer/cobalt_render_frame_observer.cc Outdated Show resolved Hide resolved
cobalt/renderer/cobalt_render_frame_observer.cc Outdated Show resolved Hide resolved
cobalt/renderer/cobalt_render_frame_observer_browsertest.cc Outdated Show resolved Hide resolved
cobalt/renderer/cobalt_render_frame_observer_browsertest.cc Outdated Show resolved Hide resolved
cobalt/renderer/cobalt_render_frame_observer_browsertest.cc Outdated Show resolved Hide resolved
yell0wd0g
yell0wd0g requested changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the browsertest!

yell0wd0g

This comment was marked as duplicate.

Sign in to view

yell0wd0g

This comment was marked as duplicate.

Sign in to view

@aee-google aee-google force-pushed the conceal branch 2 times, most recently from e8f8829 to dd8e813 Compare February 3, 2025 21:47
@aee-google aee-google requested a review from yell0wd0g February 3, 2025 21:48
yell0wd0g
yell0wd0g approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two nits.

Loved the comments! Thanks for adding them.

cobalt/configuration/configuration.cc Outdated Show resolved Hide resolved
cobalt/configuration/configuration.h Outdated Show resolved Hide resolved
yell0wd0g
yell0wd0g approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two nits.

Loved the comments! Thanks for adding them.

yell0wd0g

This comment was marked as duplicate.

Sign in to view

@aee-google aee-google enabled auto-merge (squash) February 5, 2025 01:03
@aee-google aee-google merged commit a89811c into youtube:main Feb 5, 2025
96 checks passed
@aee-google aee-google deleted the conceal branch February 5, 2025 01:44
@hlwarriner hlwarriner mentioned this pull request Feb 5, 2025
Merged
yell0wd0g added a commit that referenced this pull request Feb 6, 2025
@yell0wd0g
Revert "Add support for user on exit strategy. (#4757)"
a19cd5e 
This reverts commit a89811c.
@yell0wd0g yell0wd0g mentioned this pull request Feb 6, 2025
Merged
kaidokert pushed a commit that referenced this pull request Feb 6, 2025
@yell0wd0g
Revert "Add support for user on exit strategy." (#4858)
f88d345 
Reverts #4757 -- see b/394646160 -- tl;dr: this CL omitted
the mojo pipe to access Blink from Mojo.

Bug: b/394646160
Bug: b/385357645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yell0wd0g yell0wd0g yell0wd0g approved these changes

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

@jellefoks jellefoks Awaiting requested review from jellefoks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aee-google @yell0wd0g @andrewsavage1