starboard: Create starboard_unittest and fold in a few test targets #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test and //starboard/extension:extension_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL creates a starboard_unittests and folds in a few ...test
targets that are currently built separately (and likely not run
very often). The original
target(gtest_target_type, "bla")arerefactored into
source_set("bla").After this CL starboard_unittests runs 105 test cases, of which
only
EzTimeTExplodeTest.PositivePacificfails.Two files under //starboard/nplb/nplb_evergreen_compat_tests are
not unit tests because they rely on the starboard environment so
they are moved to nplb proper. One of the tests is unnecessary
(
VerifyCrashHandlerExtensionit's tested inExtensionTest...),and so it's removed (a note is left).
Bug: b/384819454