-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore log settings on device #4842
base: main
Are you sure you want to change the base?
Conversation
Currently if device set Android log level to Debug Chrobalt honors it. Disabling it enables us to build without Java debug logs in release builds. b/391888908
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, can we change it to use the CoAT implementation?
https://source.corp.google.com/piper///depot/google3/third_party/cobalt/app/android/coat/branch_25_lts_10/java/dev/cobalt/util/Log.java;l=92-123?q=Log.java%20f:third_party%20f:%20cobalt
This implementation can dynamically print logs with different levels, see instruction on https://g3doc.corp.google.com/company/teams/cobalt/team/first-party-ports/android/tips.md#add-logs-for-kimono
That's exactly what Log.java does. The PR here is only to strip logging in release build. |
Currently if device set Android log level to Debug Chrobalt honors it. Disabling it enables us to build without Java debug logs in release builds.
b/391888908