Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore log settings on device #4842

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

johnxwork
Copy link
Contributor

Currently if device set Android log level to Debug Chrobalt honors it. Disabling it enables us to build without Java debug logs in release builds.

b/391888908

Currently if device set Android log level to Debug Chrobalt honors it.
Disabling it enables us to build without Java debug logs in release builds.

b/391888908
@johnxwork johnxwork requested review from oxve and borongc February 4, 2025 23:55
@johnxwork johnxwork requested a review from a team as a code owner February 4, 2025 23:55
@johnxwork johnxwork requested a review from briantting February 4, 2025 23:55
@johnxwork johnxwork enabled auto-merge (squash) February 5, 2025 00:00
Copy link
Contributor

@zhongqiliang zhongqiliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhongqiliang zhongqiliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnxwork
Copy link
Contributor Author

Actually, can we change it to use the CoAT implementation? source.corp.google.com/piper///depot/google3/third_party/cobalt/app/android/coat/branch_25_lts_10/java/dev/cobalt/util/Log.java;l=92-123?q=Log.java%20f:third_party%20f:%20cobalt This implementation can dynamically print logs with different levels, see instruction on g3doc.corp.google.com/company/teams/cobalt/team/first-party-ports/android/tips.md#add-logs-for-kimono

That's exactly what Log.java does. The PR here is only to strip logging in release build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants