-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SourceBufferWriteHead to Cobalt location #4851
base: main
Are you sure you want to change the base?
Conversation
b/321297638
This is a quick look at how it may look when we move custom interface extensions to the Cobalt module. This can't build due to a dependency issue. However, I don't think we would need to deal with Mojo here. This also concerns #4837, which will need to do something similar once the process is defined |
This looks like a good change. Re Mojo, does |
It doesn't, writeHead goes as far as the ChunkDemuxerStream in the chromium media stack |
Pending verification with the web platform test. This also needs a unit test - that can be addressed in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, I copied some of this structure for #4837 and it works well.
As WPTs aren't currently working, I'll verify them later. Also, ChunkDemuxerTests are broken/unverified and need extra work to get going. I think it should be fine to merge as is and verify through tests later. I'll still verify using a Cobalt demo before merging. |
SourceBuffer.writeHead
implementation from the mediasource module to the Cobalt module.source_buffer_write_head.idl
tosource_buffer_extensions.idl
.b/395658866