Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XBOX] Workaround to crash on start nplb #4857

Draft
wants to merge 2 commits into
base: 25.lts.1+
Choose a base branch
from
Draft

[XBOX] Workaround to crash on start nplb #4857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a4184e
[XBOX] Workaround to crash on start nplb
MarekLuxoft Feb 6, 2025
b888783
Add logs
MarekLuxoft Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions starboard/nplb/multiple_player_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,6 @@ std::vector<SbPlayerMultiplePlayerTestConfig> GetMultiplePlayerTestConfigs() {
return configs_to_return;
}

INSTANTIATE_TEST_CASE_P(MultiplePlayerTests,
MultiplePlayerTest,
ValuesIn(GetMultiplePlayerTestConfigs()),
GetMultipleSbPlayerTestConfigName);

} // namespace
} // namespace nplb
} // namespace starboard
19 changes: 19 additions & 0 deletions starboard/shared/uwp/player_components_factory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,30 @@ class PlayerComponentsFactory : public PlayerComponents::Factory {
const auto is_hdr_video =
IsHdrVideo(creation_parameters.video_stream_info());

if (video_codec == kSbMediaVideoCodecH264) {
SB_LOG(WARNING) << "GOOG-110 kSbMediaVideoCodecH264.";
}
if (video_codec == kSbMediaVideoCodecVp9) {
SB_LOG(WARNING) << "GOOG-110 kSbMediaVideoCodecVp9.";
}
if (video_codec == kSbMediaVideoCodecAv1) {
SB_LOG(WARNING) << "GOOG-110 kSbMediaVideoCodecAv1.";
}
if (video_codec == kSbMediaVideoCodecH265) {
SB_LOG(WARNING) << "GOOG-110 kSbMediaVideoCodecH265.";
}
if (MftVideoDecoder::IsHardwareAv1DecoderSupported()) {
SB_LOG(WARNING) << "GOOG-110 IsHardwareAv1DecoderSupported.";
}
else {
SB_LOG(WARNING) << "GOOG-110 nope.";
}
if (video_codec == kSbMediaVideoCodecH264 ||
(video_codec == kSbMediaVideoCodecVp9 &&
MftVideoDecoder::IsHardwareVp9DecoderSupported()) ||
(video_codec == kSbMediaVideoCodecAv1 &&
MftVideoDecoder::IsHardwareAv1DecoderSupported())) {
SB_LOG(WARNING) << "GOOG-110 VideoRenderAlgorithmImpl.";
video_render_algorithm->reset(
new VideoRenderAlgorithmImpl(std::bind(GetRefreshRate)));
// The memory heap for gpu decoders isn't used by hw decoders.
Expand Down
Loading