-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Picker): should reset the second argument when the first argument… #13366
base: main
Are you sure you want to change the base?
Conversation
… is changed somehow
… is changed somehow
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13366 +/- ##
==========================================
+ Coverage 89.60% 89.77% +0.16%
==========================================
Files 257 257
Lines 7013 7021 +8
Branches 1736 1738 +2
==========================================
+ Hits 6284 6303 +19
+ Misses 384 378 -6
+ Partials 345 340 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@inottn Please help to review. I done and fixed all fail tests . |
I don't know if the previous interactions were intentional; if there is an issue, the onChange logic might need to be modified. If I have time, I will see how to adjust it. |
I definitely sure that it wasn't intentional. and it is a bug. |
thanks for point out. |
I prefer to keep the current behavior. If we reset the option it will break the user experience of date picker or time picker. |
ok, if we keep the current behavior. |
How about adding a new prop to enable this new behavior? Such as |
I think the default should be |
… is changed somehow
fixes: #13365
we should reset the second argument when the first argument is changed.
Before submitting a pull request, please read the contributing guide.
在提交 pull request 之前,请阅读 贡献指南。