fix: fixes issue with not window scroll issue (dollarshaveclub#660)

yowainwright · Feb 18, 2020 · f8de58c · f8de58c
1 parent 07831c5
commit f8de58c
Show file tree

Hide file tree

Showing 8 changed files with 28 additions and 16 deletions.
diff --git a/dist/jquery.stickybits.js b/dist/jquery.stickybits.js
@@ -326,6 +326,8 @@
     ;
 
     _proto.manageState = function manageState(item) {
+      var _this3 = this;
+
       // cache object
       var it = item;
       var p = it.props;
@@ -413,7 +415,7 @@
             classes: {}
           },
           stuck: {
-            styles: _extends((_extends2 = {}, _extends2[vp] = '', _extends2), pv === 'fixed' && !ns ? {
+            styles: _extends((_extends2 = {}, _extends2[vp] = '', _extends2), pv === 'fixed' && !ns || !_this3.isWin ? {
               position: 'absolute',
               top: '',
               bottom: '0'
@@ -477,14 +479,14 @@
     };
 
     _proto.update = function update(updatedProps) {
-      var _this3 = this;
+      var _this4 = this;
 
       if (updatedProps === void 0) {
         updatedProps = null;
       }
 
       this.instances.forEach(function (instance) {
-        _this3.computeScrollOffsets(instance);
+        _this4.computeScrollOffsets(instance);
 
         if (updatedProps) {
           // eslint-disable-next-line no-unused-vars

diff --git a/dist/jquery.stickybits.min.js b/dist/jquery.stickybits.min.js
diff --git a/dist/stickybits.es.js b/dist/stickybits.es.js
@@ -321,6 +321,8 @@ function () {
   ;
 
   _proto.manageState = function manageState(item) {
+    var _this3 = this;
+
     // cache object
     var it = item;
     var p = it.props;
@@ -408,7 +410,7 @@ function () {
           classes: {}
         },
         stuck: {
-          styles: _extends((_extends2 = {}, _extends2[vp] = '', _extends2), pv === 'fixed' && !ns ? {
+          styles: _extends((_extends2 = {}, _extends2[vp] = '', _extends2), pv === 'fixed' && !ns || !_this3.isWin ? {
             position: 'absolute',
             top: '',
             bottom: '0'
@@ -472,14 +474,14 @@ function () {
   };
 
   _proto.update = function update(updatedProps) {
-    var _this3 = this;
+    var _this4 = this;
 
     if (updatedProps === void 0) {
       updatedProps = null;
     }
 
     this.instances.forEach(function (instance) {
-      _this3.computeScrollOffsets(instance);
+      _this4.computeScrollOffsets(instance);
 
       if (updatedProps) {
         // eslint-disable-next-line no-unused-vars

diff --git a/dist/stickybits.js b/dist/stickybits.js
@@ -327,6 +327,8 @@
     ;
 
     _proto.manageState = function manageState(item) {
+      var _this3 = this;
+
       // cache object
       var it = item;
       var p = it.props;
@@ -414,7 +416,7 @@
             classes: {}
           },
           stuck: {
-            styles: _extends((_extends2 = {}, _extends2[vp] = '', _extends2), pv === 'fixed' && !ns ? {
+            styles: _extends((_extends2 = {}, _extends2[vp] = '', _extends2), pv === 'fixed' && !ns || !_this3.isWin ? {
               position: 'absolute',
               top: '',
               bottom: '0'
@@ -478,14 +480,14 @@
     };
 
     _proto.update = function update(updatedProps) {
-      var _this3 = this;
+      var _this4 = this;
 
       if (updatedProps === void 0) {
         updatedProps = null;
       }
 
       this.instances.forEach(function (instance) {
-        _this3.computeScrollOffsets(instance);
+        _this4.computeScrollOffsets(instance);
 
         if (updatedProps) {
           // eslint-disable-next-line no-unused-vars