DTVCCPacket: Avoid storing services with no codes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is invalid, only the 0 service can have no codes
|
Unit test please. |
ystreet
reviewed
Dec 16, 2024
| // Services allowed are either the padding 0 service or non-empty | ||
| // services | ||
| if service.number == 0 || !service.codes().is_empty() { | ||
| self.services.push(service); |
There was a problem hiding this comment.
Should an error be returned when the provided service is not used?
There was a problem hiding this comment.
Good point. It maybe should to inform the caller that it's doing something wrong. Is there an appropriate error type to use ?
There was a problem hiding this comment.
The error type is already a WriterError. You may need to add another value to that enum for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is invalid, only the 0 service can have no codes