Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] Migrate tools and restructure project #157

Merged
merged 17 commits into from
Mar 16, 2025
Merged

[Improve] Migrate tools and restructure project #157

merged 17 commits into from
Mar 16, 2025

Conversation

blendthink
Copy link
Member

@blendthink blendthink commented Mar 13, 2025 •
edited
Loading

Issue

Closes #147

Overview

This PR implements the migration of tools from the current repository as part of the repository reorganization:

Tool Migration

  • Removed the following tools from the current repository:
    • check_lint_rules_identity
    • update_lint_rules
  • These tools will be migrated to a new dedicated repository: flutter-yumemi-lints-tools

Project Structure Improvements

  • Simplified the project structure by:
    • Moving files from packages/yumemi_lints to the root directory
    • Properly organizing lint rule files under version-specific directories

Configuration Updates

  • Updated Dart SDK version from 3.1.0 to 2.17.0 in .dvm/config.json
  • Removed Melos dependency for simpler package management
  • Updated various configuration files for better development experience:
    • Modified .gitignore
    • Added cspell.json
    • Updated VSCode settings

Documentation Updates

  • Relocated CHANGELOG.md to the root directory
  • Updated installation and contribution guidelines
  • Removed outdated documentation

Impact

  • Improved repository organization by separating lint rules from maintenance tools
  • Better maintainability through simplified project structure
  • Clearer separation of concerns between the lint package and its maintenance tools

Testing

  • Verify all lint rules are working correctly after tool removal
  • Ensure the package can be properly published
  • Confirm the example project works as expected

Additional Notes

The removed tools will be available in the new repository: flutter-yumemi-lints-tools

@blendthink
docs: Fix branch name format
185bc38
@blendthink
docs: Remove GitHub Copilot documentation and update GET_STARTED.md
f725a76
@blendthink
docs: Update target directories in contribution guidelines
e74fa79
@blendthink
fix: Update VSCode launch configuration formatting
7aae6f6 
- Add trailing commas in launch.json
- Adjust formatting to match code style
@blendthink
chore(deps): pin GitHub Actions to specific commit hashes
1e42042 
- Update actions/checkout to v4.2.2
- Update blendfactory/dvm-config-action to v2.0.0
- Update dart-lang/setup-dart to v1.7.1
@blendthink
feat(ci): add GitHub App token generation and adjust checkout settings
d09a0e0 
- Add GitHub App token generation step for authentication
- Update program directory path to tool/tools/check_lint_rules_identity
- Modify checkout settings to fetch full history and use custom path
@blendthink
fix(ci): use github.workspace context instead of WORKSPACE env var
1248d62 
- Replace $WORKSPACE with ${{ github.workspace }} for better reliability in GitHub Actions
@blendthink
chore(deps): pin GitHub Actions to specific commit hashes
c5ac77c
@blendthink
feat(ci): configure GitHub App authentication for update-lint-rules w…
975f6e1 
…orkflow

- Add GitHub App token generation for secure authentication
- Set up program directory environment variable
- Configure custom checkout path for better workspace organization
@blendthink blendthink changed the title Gh 147 [Improve] Migrate tools and restructure project Mar 16, 2025
@blendthink blendthink marked this pull request as ready for review March 16, 2025 10:45
@github-actions GitHub Actions
Copy link
Contributor

Ready for review 🚀

@blendthink
Copy link
Member Author

I've tested it and it seems to be working fine overall, so I'll merge it. Let me know if any issues come up.

@blendthink blendthink merged commit 803a7cb into main Mar 16, 2025
3 of 4 checks passed
@blendthink blendthink deleted the GH-147 branch March 16, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K9i-0 K9i-0 Awaiting requested review from K9i-0

@morikann morikann Awaiting requested review from morikann

@trm11tkr trm11tkr Awaiting requested review from trm11tkr

@Yamasaki-pan961 Yamasaki-pan961 Awaiting requested review from Yamasaki-pan961

@YumNumm YumNumm Awaiting requested review from YumNumm

Assignees

@blendthink blendthink

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve]: Move tools directory to new repository flutter-yumemi-lints-tools
1 participant
@blendthink