Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: diagrams.net - add /health API for health checks #1811

Merged
merged 2 commits into from
Feb 23, 2025

Conversation

quytm
Copy link
Contributor

@quytm quytm commented Nov 26, 2024

Hi team,

I found that diagrams.net is missing /health for the health check. That may lead to a failure in K8s when starting the instance, so I created this pull request to support it.

Please review it and give me comments if any!

Thank you!

Add `/health` for diagrams.io for supporting health check
@quytm quytm changed the title chore: add /health API for health checks diagrams.io chore: diagrams.io - add /health API for health checks Nov 26, 2024
@quytm quytm changed the title chore: diagrams.io - add /health API for health checks chore: diagrams.net - add /health API for health checks Nov 26, 2024
@ggrossetie
Copy link
Member

Thanks @quytm !
We still need to work on #1423 but I think it's fine to add the /health endpoint since we already have it in other services.

@ggrossetie ggrossetie merged commit 30f02c3 into yuzutech:main Feb 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants