-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws: log when multiple subnets found in the same AZ #659
Draft
AlexanderYastrebov
wants to merge
1
commit into
master
Choose a base branch
from
aws/log-multiple-az-subnets
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
aws/log-multiple-az-subnets
branch
2 times, most recently
from
November 20, 2023 15:55
a986c77
to
3b00624
Compare
AlexanderYastrebov
force-pushed
the
aws/log-multiple-az-subnets
branch
from
November 20, 2023 16:18
3b00624
to
41b0d3c
Compare
AlexanderYastrebov
force-pushed
the
aws/log-multiple-az-subnets
branch
from
November 20, 2023 16:30
41b0d3c
to
83f8db9
Compare
Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
aws/log-multiple-az-subnets
branch
from
November 20, 2023 16:31
83f8db9
to
681bb78
Compare
👍 |
This makes sense to have only when subnets are tagged with cluster id kube-ingress-aws-controller/aws/ec2.go Lines 193 to 207 in 6780b71
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#0