empty structs should not lead to wrong detection (#589)

zalando-incubator · Feb 19, 2024 · 9e24210 · 9e24210
1 parent 4200e91
commit 9e24210
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/apis/zalando.org/v1/types.go b/pkg/apis/zalando.org/v1/types.go
@@ -459,12 +459,12 @@ func (crs *ConfigurationResourcesSpec) GetName() string {
 
 // IsConfigMap returns true if the ConfigurationResourcesSpec is a ConfigMap.
 func (crs *ConfigurationResourcesSpec) IsConfigMap() bool {
-	return crs.ConfigMapRef != nil
+	return crs.ConfigMapRef != nil && crs.ConfigMapRef.Name != ""
 }
 
 // IsSecret returns true if the ConfigurationResourcesSpec is a Secret.
 func (crs *ConfigurationResourcesSpec) IsSecret() bool {
-	return crs.SecretRef != nil
+	return crs.SecretRef != nil && crs.SecretRef.Name != ""
 }
 
 // StackSpecInternal is the spec part of the Stack, including `ingress` and