Add transparent address gap limit handling & general address rotation functionality. #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
feature/transparent_gap_limit_handling
branch
16 times, most recently
from
62c1394 to
bd2df86
Compare
nuttycom
changed the title
nuttycom
force-pushed
the
feature/transparent_gap_limit_handling
branch
from
bd2df86 to
4b99663
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
==========================================
+ Coverage 54.17% 54.26% +0.08%
==========================================
Files 176 179 +3
Lines 20469 21243 +774
==========================================
+ Hits 11089 11527 +438
- Misses 9380 9716 +336 ☔ View full report in Codecov by Sentry. |
nuttycom
force-pushed
the
feature/transparent_gap_limit_handling
branch
2 times, most recently
from
1386dd1 to
49230de
Compare
str4d
added a commit
that referenced
this pull request
Dec 30, 2024
…handling-prep Preparatory refactoring for #1673
nuttycom
force-pushed
the
feature/transparent_gap_limit_handling
branch
2 times, most recently
from
b39c6c3 to
3ac0396
Compare
str4d
reviewed
Dec 30, 2024
str4d
reviewed
Dec 30, 2024
daira
reviewed
Mar 4, 2025
| account_id, | ||
| key_scope, | ||
| &wdb.gap_limits, | ||
| UnifiedAddressRequest::unsafe_custom(Allow, Allow, Require), |
There was a problem hiding this comment.
Same issue here as for https://github.com/zcash/librustzcash/pull/1673/files#r1978625962
daira
reviewed
Mar 4, 2025
daira
reviewed
Mar 4, 2025
| account.internal_id(), | ||
| KeyScope::EXTERNAL, | ||
| gap_limits, | ||
| UnifiedAddressRequest::unsafe_custom(Allow, Allow, Require), |
There was a problem hiding this comment.
daira
reviewed
Mar 4, 2025
| .expect("gap limit fits in usize"), | ||
| )?; | ||
|
|
||
| // Find the first index that generates an address conforming to the request. |
There was a problem hiding this comment.
Did we resolve the issue with there being a significant probability of not finding any Sapling addresses within the gap limit?
daira
reviewed
Mar 4, 2025
daira
reviewed
Mar 4, 2025
| account_id, | ||
| key_scope, | ||
| gap_limits, | ||
| UnifiedAddressRequest::unsafe_custom(Allow, Allow, Require), |
There was a problem hiding this comment.
Same issue here as https://github.com/zcash/librustzcash/pull/1673/files#r1978625962
daira
reviewed
Mar 4, 2025
Comment on lines
+85
to
+87
| /// This column exists because the diversifier index is stored as a byte array, meaning that we | ||
| /// cannot use SQL integer operations on it for gap limit calculations, and thus need it as an | ||
| /// integer as well. |
There was a problem hiding this comment.
It occurs to me that we could store the diversifier index as pairs of SQL integers, the high 56 bits and the low 32 bits. That would be normalized, easily sortable in SQL, and easy to check in SQL that the high bits are all 0. Filed #1731.
daira
reviewed
Mar 4, 2025
daira
reviewed
Mar 4, 2025
daira
reviewed
Mar 4, 2025
daira
reviewed
Mar 4, 2025
zcash_client_sqlite/src/wallet/init/migrations/ephemeral_addresses.rs
Outdated
Show resolved
Hide resolved
daira
reviewed
Mar 4, 2025
zcash_client_sqlite/src/wallet/init/migrations/transparent_gap_limit_handling.rs
Outdated
Show resolved
Hide resolved
daira
reviewed
Mar 4, 2025
daira
reviewed
Mar 4, 2025
daira
reviewed
Mar 4, 2025
| find_gap_start(&db.conn, account_id, KeyScope::Ephemeral, db.gap_limits.ephemeral()), Ok(addr_index) | ||
| if addr_index == Some(NonHardenedChildIndex::ZERO) | ||
| ); | ||
| //assert_matches!(ephemeral::first_unstored_index(&db.conn, account_id), Ok(addr_index) if addr_index == GAP_LIMIT); |
There was a problem hiding this comment.
Is this assertion correct? Delete it if it isn't correct, otherwise uncomment it. Non-blocking.
daira
previously approved these changes
Mar 4, 2025
daira
force-pushed
the
feature/transparent_gap_limit_handling
branch
from
a93fb07 to
12e1a10
Compare
daira
force-pushed
the
feature/transparent_gap_limit_handling
branch
from
12e1a10 to
635c94b
Compare
Co-authored-by: Jack Grigg <[email protected]> Signed-off-by: Daira-Emma Hopwood <[email protected]>
…uts" feature is not enabled. Signed-off-by: Daira-Emma Hopwood <[email protected]>
Signed-off-by: Daira-Emma Hopwood <[email protected]>
daira
force-pushed
the
feature/transparent_gap_limit_handling
branch
from
635c94b to
19e0e39
Compare
daira
approved these changes
Mar 4, 2025
str4d
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.