Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(app): add missing Qt components to find_package #1644

Merged
merged 2 commits into from
Jul 28, 2024

Commits on Jul 27, 2024

  1. build: add missing Qt6 components to find_package.

    Fixes zealdocs#1643.
    
    Starting from Qt 6.7.2 it is necessary to list all necessary components
    for Qt6 rather than deferring them. This commit fixes a build failure
    when cmake configures a build against Qt >= 6.7.2, where we otherwise
    see a failure like:
    
    ```
    [   14s] CMake Error at
    /usr/lib64/cmake/Qt6/QtPublicWalkLibsHelpers.cmake:259 (message):
    [   14s]   The Concurrent target is mentioned as a dependency for
    Registry, but not
    [   14s]   declared.
    [   14s] Call Stack (most recent call first):
    [   14s]   /usr/lib64/cmake/Qt6/QtPublicWalkLibsHelpers.cmake:228
    (__qt_internal_walk_libs)
    [   14s]   /usr/lib64/cmake/Qt6/QtPublicWalkLibsHelpers.cmake:311
    (__qt_internal_walk_libs)
    [   14s]   /usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:651
    (__qt_internal_collect_all_target_dependencies)
    [   14s]   /usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:774
    (_qt_internal_finalize_executable)
    [   14s]   /usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:590:EVAL:1
    (qt6_finalize_target)
    [   14s]   src/app/CMakeLists.txt:DEFERRED
    ```
    
    and so on for all missing components.
    badshah400 committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    c722b29 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Configuration menu
    Copy the full SHA
    75e17c1 View commit details
    Browse the repository at this point in the history