Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpui: Add platform-specific keystroke display #23979

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

KorigamiK
Copy link
Contributor

Closes #21938

Release Notes:

  • Added: platform specific keystroke display

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 30, 2025
@KorigamiK KorigamiK changed the title platform specific keystroke display Platform specific keystroke display Jan 30, 2025
@maxdeviant maxdeviant changed the title Platform specific keystroke display gpui: Add platform-specific keystroke display Jan 30, 2025
@mikayla-maki
Copy link
Contributor

Can we see a before and after of this on any platforms you have access to? It looks like this changes the macOS keybindings to have + between them, and we don't want that :)

@KorigamiK
Copy link
Contributor Author

KorigamiK commented Feb 7, 2025

Can we see a before and after of this on any platforms you have access to? It looks like this changes the macOS keybindings to have + between them, and we don't want that :)

yeah, i fixed the separator on macos and other platforms which looks like this:

macos linux
image image

note that i dont have a mac to test so both are taken from my linux machine only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alt key icon is incorrect on Linux
2 participants