Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_icons: Use separate icon key for JSON files #24432

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

sethstha
Copy link
Contributor

@sethstha sethstha commented Feb 7, 2025

This PR updates the file icon mappings for JSON (.json) file map to thejson key. Also, updates .json icon from storage to code.

This allows for the JSON file icons to be replaced in icon themes.

Release Notes:

  • Icon themes: Added the ability to change the file icon for JSON (.json) files.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 7, 2025
@maxdeviant maxdeviant self-assigned this Feb 7, 2025
@maxdeviant maxdeviant changed the title file_icons: Use separate icon key for JSON file file_icons: Use separate icon key for JSON files Feb 7, 2025
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maxdeviant maxdeviant enabled auto-merge (squash) February 7, 2025 16:08
@maxdeviant maxdeviant merged commit c7cd5b0 into zed-industries:main Feb 7, 2025
12 checks passed
@sethstha sethstha deleted the icon-key-json branch February 8, 2025 00:22
maxdeviant pushed a commit to zed-extensions/material-icon-theme that referenced this pull request Feb 8, 2025
This PR adds icon support for `JSON` file. Also addresses #10. While,
there is alreay `json.svg` file in `icons` folder there is no support
for it.

`JSON` key has been already added on core via this PR
[24432](zed-industries/zed#24432)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants