You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice to modify watch_filesystem to take in a list of folders to watch. The reasons for doing this are:
Avoid doing unnecessary work watching files we don't care about.
Currently, this watches the /host folder and recurses through all child folders. As a result, if the user doesn't have access to a file in the /host folder or child folders, this results in an error. Restricting the folders watched to the minimum required should limit this happening.
To make this change, watch_filesystem could be modified from this function signature
If watch_filesystem is called with an empty HashMap, we can fill it with /host and true to get the previous behavior.
The downside of this is the function signature of watch_filesystem will change, which means any plugins using it will need to update this call. This doesn't seem to be used much in the zellij core. There was only one instance of it in the core, and it was for a test. multitask is another plugin I know that uses this, and I will update said plugin if this change is made.
I've got this implemented and tested on a local fork. Would be happy to submit a PR if this is accepted (or modify and submit a PR based on any discussion here).
The text was updated successfully, but these errors were encountered:
It would be nice to modify
watch_filesystem
to take in a list of folders to watch. The reasons for doing this are:/host
folder and recurses through all child folders. As a result, if the user doesn't have access to a file in the/host
folder or child folders, this results in an error. Restricting the folders watched to the minimum required should limit this happening.To make this change,
watch_filesystem
could be modified from this function signatureto
If
watch_filesystem
is called with an emptyHashMap
, we can fill it with/host
andtrue
to get the previous behavior.The downside of this is the function signature of
watch_filesystem
will change, which means any plugins using it will need to update this call. This doesn't seem to be used much in the zellij core. There was only one instance of it in the core, and it was for a test.multitask
is another plugin I know that uses this, and I will update said plugin if this change is made.I've got this implemented and tested on a local fork. Would be happy to submit a PR if this is accepted (or modify and submit a PR based on any discussion here).
The text was updated successfully, but these errors were encountered: