-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify watch_filesystem to take in a list of folders to watch #3377
Conversation
defines the folders we want to watch and whether to recurse through them or not. An empty map will result in the /host folder being watched with recurse=true.
Hey @leakec - I first wanted to apologize for taking so embarrassingly long to get to this. Otherwise - I'm a little concerned about the current watch_filesystem as I find it quite buggy on certain platforms and I'm not sure I want to keep giving plugins so much power over the application. I guess you want this for |
@imsnif No need to apologize at all. I know you are super busy maintaining this awesome tool we all love and enjoy! You're correct in that this PR was targeting some improvements I was hoping to make on One option would be to just have Sounds good r.e. the APIs in the upcoming version. I'll read the updates when it comes out and let you know if I have any questions. I'm happy to close this PR rather than merge if you think that's best. |
The new version includes APIs that will allow you to open a file in an
It will also be much easier to do the actual multitasking because there are also APIs for doing the same thing with command panes. Up to you though, of course! Otherwise, let's leave this PR open for now. If you decide you want to go this direction after all, we can re-examine it. |
@imsnif This sounds great! I think it might be nice to add a second way in addition to closing the editor pane (maybe an optional, opt-in keybind or something) so users can run the multitask with the editor window still open. This is really nice if the tasks run fast and you want to run them, make a change, run them again, etc. Regardless, it sounds like all of this will fit really nicely within the new API :) I like this plan a lot better than the PR here, since then we don't have to worry about permission for anything except the multitask file and running the commands, so we don't have to even worry about watching any part of the file sytem. Therefore, I'm going to close the PR. Thanks for all the suggestions and work on the upcoming, new API options! |
This pull request addresses issue #3325.