If simplified_ui is set to true, it doesn't print messages on client startup/exit.
#3437
+28,586
−4,824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client startup/exit. Although this is mostly bikeshedding, I believe it helps with UI consistency.
Tomcat-42
changed the title
simplified_ui is set to tue, it doesn't print messages on client startup/exit.simplified_ui is set to true, it doesn't print messages on client startup/exit.
* Remove ForeignFunctionEnv wrapper around PluginEnv This will enable PluginEnv to be the Store context when migrating to Wasmtime. * Pass PluginEnv by value to load_plugin_instance This will allow removing the Clone impl from PluginEnv when migrating to Wasmtime as required by the missing Clone impl on Wasmtime's WasiCtx. * Avoid passing a Store around when an Engine is enough * Pass PluginEnv to the wasi read/write functions Wasmtime requires storing the read/write end of the pipe outside of the WasiCtx. Passing PluginEnv to these functions allows storing them in the PluginEnv. * Migrate to Wasmtime * Switch from wasi-common to wasmtime-wasi * Reduce verbosity of wasmtime_wasi logs * Increase startup delay To wait for all plugins to be compiled. * Disable some wasmtime features * Update to Wasmtime 21.0.1
* work * work * working * get default mode from server and some ui responsiveness * work * finish design and get tests to pass * get e2e tests to pass * add classic layout * add classic layout assets * fix e2e tests * style(fmt): rustfmt * fix plugin system test * style(fmt): some cleanups
* cargo: Remove `rust-version` (msrv) field from `Cargo.toml`. This has gone out of sync with the rust version specified in `rust-toolchain.toml` and appears to have little consequence to development, since it defines only the MSRV. We're using `rust-toolchain.toml` to strictly enforce a specific rust version for development, hence we stick with that. Closes zellij-org#3476 * CHANGELOG: Add MR zellij-org#3480.
zellij-org#3483) * fix(terminal): properly cache cursor position for synchronized renders * style(fmt): rustfmt
* cargo: Reintroduce `rust-version` field in `Cargo.toml` since it appears that client-side `cargo` will check this field and [error when the users rust toolchain is too old][1]. Add comments in `Cargo.toml` and `rust-toolchain.toml` pointing to each other so the rust versions mentioned in each file are hopefully kept in sync in the future. [1]: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field * CHANGELOG: Add MR zellij-org#3482.
…ime (zellij-org#3502) * rebind => reconfigure * persist keybinds and mode info to new tabs * add configuration plugin * make tests pass * remove warnings * style(fmt): rustfmt
* fix(serialization): do not serialize junk sessions * style(fmt): rustfmt
…org#3505) * fix(startup): do not parse resurrectable sessions on startup * style(fmt): rustfmt
Co-authored-by: Bruno Mesquita <[email protected]>
Onedark is a popular theme from Atom text editor. I've used these sources as the reference for implementing the theme in zellij. https://github.com/joshdick/onedark.vim https://www.figma.com/community/file/1137445418485757476/atom-one-dark-color-palette
the previous themes do not have the correct colors and aren't great for the eyes. when selecting e.g. to copy text, it uses red for light theme and the same bg for dark theme. the previous light theme is not even a light theme so I also fixed that as well. Signed-off-by: Soc Virnyl Estela <[email protected]>
…ane (zellij-org#3498) Co-authored-by: Vasilis Manolopoulos <[email protected]>
* fix(startup): try create config folder if it doesn't exist * fix(configuration): tab bar ui * fix(configuration): rebind ctrl-s to ctrl-a * fix(configuration): remove extra rebinding leaders screen
…n hard-coded normal mode (zellij-org#3715) * fix(keybindings): only forward clear keys in locked mode and default mode * style(fmt): rustfmt
* fix(input): refix ctrl-j * fix e2e tests
* fix(plugins): maintain cwd between plugin reloads * fix(plugin-manager): default to loading plugins in the foreground and allow sending space in configuration
…ellij-org#3750) * fix(output-buffer): truncate grid height when not rendering it fully * also fix for cases where the changed lines are not contiguous
|
Hello @imsnif, could you please take a look? 🥺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this is mostly bikeshedding, I believe it helps with UI consistency.
Additionally, this can make the shell startup smoother by removing the annoying "loading zellij" message before the shell rendering.