feat(cli): Add alive option to ls
#3510
Open
+29
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3168
In the end, I added the flag with the name
alive, which I think is reasonable. Of course it can still be bikeshed, but since the issue hadn't had activity for a few months so I decided to go forward with what I think sounds best!I think it might make sense to only show alive session by default and have another
--exitedor--show-exitedflag, but that would change the current behavior, so I figured I'd let a maintainer take that decision.As an FYI, I tried to run and test everything locally, but I couldn't get it to compile (the problem is some missing
target/../wasm32-wasi/...plugin thingy) but the changes seem simple so I hope it just works 😅