Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(themes): adjust catppuccin-latte & add comments #3579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgoudham
Copy link

@sgoudham sgoudham commented Aug 31, 2024

Hey 👋, this PR introduces some changes as part of merging catppuccin/zellij#11 downstream.

We noticed that the fg and bg keys for catppuccin-latte were the same which seemed incorrect, however, we couldn't find any noticeable changes on the UI when changing these keys. Catppuccin Latte now (properly) uses surface2 for the background and text for the foreground, matching the other existing flavours. Furthermore, black is now mapped to mantle, also matching the other existing flavours.

I'd appreciate any insight into why Catppuccin Latte seemed to function well even with the foreground and background keys set to the same colour.

I've also added comments to map white and fg to the Catppuccin palette colour of text.

Hope these changes are fine and let me know if there's anything else I need to edit, thanks!

@jaeheonji jaeheonji self-assigned this Oct 5, 2024
@imsnif
Copy link
Member

imsnif commented Oct 10, 2024

Hey @sgoudham and @jaeheonji - I didn't notice this PR, and when working on some fixes for the new UI I also noticed this issue. I changed fg to #5c5f77 (Subtext 1) because it looked best to me. In our context it's mostly about adjusting the color of unselected ribbons. Here's an example of how it looks in the new UI:

img-2024-10-10-162606
img-2024-10-10-162546

What do you think?

Otherwise (maybe related, maybe not) I'm a little concerned about the contrast of the magenta and red variants (as can be seen in these screenshots with Ctrl g and <n> New Pane (the n part) respectively). Do you have any thoughts?

@jaeheonji
Copy link
Member

Hey! Sorry for late reply.

When I first added the catppuccin theme to zellij, I added it slightly differently from the catppuccin color rules. The reason is that because of some UI errors and unused colors that we had previously, I added the most appropriate color expression to zellij at that time.

In my opinion, I think it is fine to modify the color palette suitable for zellij as long as the look and feel of the theme matches. So, @imsnif I think that one looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants