Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes findDOMNode errors for react 18 #980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wesrog
Copy link

@wesrog wesrog commented May 31, 2024

No description provided.

@wesrog wesrog mentioned this pull request May 31, 2024
8 tasks
lassespilling added a commit to lassespilling/react-quill-2024 that referenced this pull request Jun 18, 2024
@lassespilling
Copy link

lassespilling commented Jun 18, 2024

You can use this meanwhile, added your fix here:
npm i react-quill@https://github.com/lassespilling/react-quill-2024/tree/package

@M-Farmaha
Copy link

You can use this meanwhile, added your fix here: npm i react-quill@https://github.com/lassespilling/react-quill-2024/tree/package

Thanks. It works

@hamidrezahanafi
Copy link

@lassespilling Thanks for the repo, do you mind publishing a package with your fix? with yarn v1 and I can't use your changes

@sunjae-kim
Copy link

@lassespilling Thanks for the repo!!

I noticed this library uses 'DOMNodeInserted' events, which are deprecated. Any plans to switch to MutationObserver? Happy to provide more info if needed.

Thanks for maintaining this project!

@Defconn4
Copy link

Defconn4 commented Aug 8, 2024

@lassespilling Thanks for the repo!!

I noticed this library uses 'DOMNodeInserted' events, which are deprecated. Any plans to switch to MutationObserver? Happy to provide more info if needed.

Thanks for maintaining this project!

This would be incredibly helpful! I am currently running into this issue with my use of this repository.

I have not 100% identified the issue within my codebase but I believe the following error in conjunction with custom logic built on top of my React-Quill editor causing content to be wiped from my React-Quill editor when users copy and paste content into the editor.

For context, here is the full console warning for any maintainers 🙏

Deprecation] Listener added for a 'DOMNodeInserted' mutation event. This event type is deprecated, and will be removed from this browser very soon. Usage of this event listener will cause performance issues today, and represents a large risk of future site breakage. Consider using MutationObserver instead. See https://chromestatus.com/feature/5083947249172480 for more information.

@hamidrezahanafi
Copy link

use react-quill-new for React 19 support https://www.npmjs.com/package/react-quill-new

@DamithaPerera
Copy link

use react-quill-new for React 19 support https://www.npmjs.com/package/react-quill-new

This is also not working... Im getting the same error
[Deprecation] Listener added for a 'DOMNodeInserted' mutation event. Support for this event type has been removed, and this event will no longer be fired. See https://chromestatus.com/feature/5083947249172480 for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants