Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support: added recaptcha #98

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

support: added recaptcha #98

wants to merge 1 commit into from
+45 −9

Conversation

alejandromumo
Copy link
Member

closes #83

@alejandromumo alejandromumo marked this pull request as draft November 21, 2022 12:47
@alejandromumo
Copy link
Member Author

The google client key is being injected in the DOM, leaving it open to read. That is not ideal in terms of security.

I tried to pass the key using an environment variable but I could not make it work. It seems invenio-assets is currently replacing process.env for process.env.NODE_ENV and I don't find any other way to pass other variables.

The PR is therefore in draft until this can be properly implemented (without exposing the client key)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support form: add re-captcha
1 participant
@alejandromumo