-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename some (wrong named) macro in samv71q-pinctrl.h for AFEC0 pins #39
base: master
Are you sure you want to change the base?
Conversation
The pin macro for SAM V71 Q relative to PE5 use as AFEC0 AD3 is now named PE5X_AFE0_AD3. Previously it was named as if it is relative to AFEC1 AD3 (PE5X_AFE1_AD3). A check can be made by reading the pinout table of ATSAMV71 for 144 pinout (datasheet: https://ww1.microchip.com/downloads/aemDocuments/documents/MCU32/ProductDocuments/DataSheets/SAM-E70-S70-V70-V71-Family-Data-Sheet-DS60001527.pdf) (start fo the table: page 28; relevant table section: page 33, LQFP pin 28).
note that I didn't change the comment above the macro definition |
Renamed the macro for PE4 for AFEC0 AD4 functionality to actually reflect the configuration. It was previously named as if it is for AFEC1.
Update comments related to misnaming from AFEC1 to AFEC0
I think the changes for AD pins for AFEC0 / AFEC1 are done. I have tested on the EVB of ATSAMV71Q21B (the sam_v71_xult board) by using a custom board folder with inside the devicetree (common and pinctrl). |
Hi @zebo9x , Yes, you are right. There is a typo in the pinconfig file: hal_atmel/pinconfigs/sam-s70-e70-v7x.yml Lines 802 to 815 in 56d60eb
You should fix in there and regenerate the files. There are documentation in the repo that explains how it works. |
Hi @zebo9x, Is there any news from your side? |
The pin macro for SAM V71 Q relative to PE5 use as AFEC0 AD3 is now named PE5X_AFE0_AD3. Previously it was named as if it is relative to AFEC1 AD3 (PE5X_AFE1_AD3). A check can be made by reading the pinout table of ATSAMV71 for 144 pinout (datasheet: https://ww1.microchip.com/downloads/aemDocuments/documents/MCU32/ProductDocuments/DataSheets/SAM-E70-S70-V70-V71-Family-Data-Sheet-DS60001527.pdf) (start fo the table: page 28; relevant table section: page 33, LQFP pin 28).