stm32 uart/spi/adc: support DMA when CONFIG_MEM_ATTR=n #87757
+11
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: STM32
github-actions
bot
requested review from
anangl,
dcpleung,
djiatsaf-st,
erwango,
FRASTM,
GeorgeCGV,
marwaiehm-st,
mathieuchopstm,
tbursztyka and
teburd
JarmouniA
reviewed
Mar 27, 2025
There was a problem hiding this comment.
@etienne-lms @erwango Another idea, let's just guard the cache management code that uses mem attributes with CONFIG_MEM_ATTR, and make it possible to use DMA with DCache but without mem attributes. Nocache region can still be used via CONFIG_NOCACHE_MEMORY for example.
|
Right, good idea. I'll update accordingly. |
etienne-lms
force-pushed
the
stm32-drv-mem-attr
branch
from
58ff230 to
a95247a
Compare
erwango
previously approved these changes
Mar 27, 2025
JarmouniA
suggested changes
Mar 27, 2025
Allow STM32 UART driver to operate with DMA support even when CONFIG_MEM_ATTR is disabled which happen when CONFIG_ARM_MPU is intentionally disabled despite the CPU supports MPU. By the way, remove some #ifdef directive on header files inclusion that add noise in the header file inclusion section without any benefit. Signed-off-by: Etienne Carriere <[email protected]>
Allow STM32 SPI driver to operate with DMA support even when CONFIG_MEM_ATTR is disabled which happen when CONFIG_ARM_MPU is intentionally disabled despite the CPU supports MPU. By the way, remove some #ifdef directive on header files inclusion that add noise in the header file inclusion section without any benefit. Signed-off-by: Etienne Carriere <[email protected]>
Allow STM32 ADC driver to operate with DMA support even when CONFIG_MEM_ATTR is disabled which happen when CONFIG_ARM_MPU is intentionally disabled despite the CPU supports MPU. By the way, remove some #ifdef directive on header files inclusion that add noise in the header file inclusion section without any benefit. Also remove inclusion of zephyr/arch/cache.h that is not needed at all. Signed-off-by: Etienne Carriere <[email protected]>
Allow STM32 I2C driver v2 to operate with DMA support even when CONFIG_MEM_ATTR is disabled which happen when CONFIG_ARM_MPU is intentionally disabled despite the CPU supports MPU. By the way, remove a #ifdef directive on header files inclusion that adds noise in the header file inclusion section without any benefit. Signed-off-by: Etienne Carriere <[email protected]>
JarmouniA
approved these changes
Mar 28, 2025
etienne-lms
force-pushed
the
stm32-drv-mem-attr
branch
from
a95247a to
f17d841
Compare
|
Rebased (to fix merge conflict). |
etienne-lms
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit that some configurations of the STM32 ADC, SPI and UART drivers requireCONFIG_MEM_ATTR=y.(edited)
Allow STM32 SPI/ADC/UART/I2C drivers to operate with DMA support even when
CONFIG_MEM_ATTRis disabled which happen whenCONFIG_ARM_MPUis intentionally disabled despite the CPU supports MPU.By the way, remove some #ifdef directive on header files inclusion that add noise in the header file inclusion section without any benefit.
These changes do not fix existing issues but are proposed to prevent later issues, as mentioned in #87681 (comment).