enh: add compwa compatibility #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-eschle
force-pushed
the
compwa
branch
3 times, most recently
from
b475a5f to
fc7628e
Compare
for more information, see https://pre-commit.ci
Added ignore patterns to the check-manifest tool to exclude .tox directories, test files, and specific Python files like __init__.py and _version.py. This helps streamline the manifest checks and avoid unnecessary file inclusions.
This commit integrates ComPWA framework support, allowing the use of ComPWA loss functions and PDFs within zfit minimizers. Additionally, it updates relevant documentation and ensures that all necessary components are publicly accessible through `__all__` definitions.
Removed unnecessary imports and commented-out code to clean up the `test_compwa_wrapper.py` file. Also added TODO comments for further investigation regarding cached functionalities.
Removed unnecessary imports and commented-out code to clean up the `test_compwa_wrapper.py` file. Also added TODO comments for further investigation regarding cached functionalities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Tests added
Checklist