Renamed Velocity to Speed Fix/#369 #561

ealvesss · 2023-12-29T17:20:37Z

it was changed total of 27 files.
I'm using vsCode and it was creating a vscode profile folder, so I already added this folder in .gitignore file. Case it is a problem I can Separate the commits.

Check if it fits the spectation and let me know.

😄

(I didn't know which name should use in branch, so I put the number of the issue, hope its ok.)

kemenaran · 2023-12-31T13:25:36Z

Thanks for the PR!

As the discussion in the issue suggested, we actually settled on the inverse renaming: renaming everything from Speed to Velocity. The issue title remained the same, and so was misleading; sorry.

So the idea would be to do the inverse renaming (except maybe for cases where the symbol refers to an actual property of an entity, like the constant defining the speed at which it can move. But we just do a bulk rename for now, and catch the remaining tangential cases later).

ealvesss · 2023-12-31T15:42:05Z

Oh @kemenaran so I missunderstood! The right way is the oposite! I will fix here then append the commit to the pr.

Sorry about that!

ealvesss · 2023-12-31T15:55:24Z

The issue title remained the sa

I've searched in the project and it founded

176 files
- 2338 occurences

So, as you mentioned above, it would be better to use the "batch rename" approach and fix some specific points that we eventually find in the code.

p.s: I don't know if will be possible solve it today, but I will fix ASAP!

cheers 🎉

ealvesss

The issue title was wrong, so I missunderstood what I should rename to.

Now, it looks like was renamed properly (I hope so 😄 )

ealvesss · 2023-12-31T18:35:11Z

@kemenaran fixed it. If I missed something just let me know! By the way, Happy New Year 🎉

kemenaran

Thanks! A few notes:

Sometimes the casing is wrong: "speed" (lowercase) gets replaced by "Velocity" (uppercase capital). You may want to replace "speed" with "velocity" and "Speed" with "Velocity"
Sometimes "speed" is replaced in a sentence belonging to a code comment. I think these should mostly stay the same than before. To help you may want to replace "speed" by "velocity" only if it is part of a symbol. A regex could help here: performing the replacement only if there's a non-space character just before or just after (so that "LinkSpeedX" gets replaced, but "adjust speed of music" doesnt).
It seems you added a "revisions/P0" directory by mistake :)

Otherwise it looks good to me. Thanks for your work, and happy new year!

kemenaran · 2023-12-31T13:20:16Z

.gitignore

@@ -35,3 +35,11 @@ DumpBanks
 # save files
 *.sav
 *.ss*
+
+### VisualStudioCode ###


Suggested change

### VisualStudioCode ###

# visual studio code

Also, if you feel you can split this into another commit, that'd be great (but otherwise fine)

kemenaran · 2023-12-31T21:28:01Z

README.md

@@ -51,7 +51,7 @@ You can also read [disassembling How-Tos](https://github.com/zladx/LADX-Disassem
 - [Artemis251's Link's Awakening Cache](http://artemis251.fobby.net/zelda/index.php): ROM map, maps data format
 - [Xkeeper's Link's Awakening depot](https://xkeeper.net/hacking/linksawakening/): maps tilesets and save format infos
 - [LALE](https://github.com/anotak/LALE): level editor, notes on maps data format
- [The Legend of Zelda Link's Awakening /DX Speedrunning Wiki](http://spiraster.x10host.com/LADXWiki/index.php/) : infos on wrong warps and map data format
+- [The Legend of Zelda Link's Awakening /DX Velocityrunning Wiki](http://spiraster.x10host.com/LADXWiki/index.php/) : infos on wrong warps and map data format


This shouldn't be replaced by "velocity"

kemenaran · 2023-12-31T21:28:35Z

src/constants/memory/wram.asm

-; 1 = double-speed,
-; 2 = half-speed
+; 1 = double-Velocity,
+; 2 = half-Velocity


We want to keep "speed" here.

kemenaran · 2023-12-31T21:33:11Z

src/constants/memory/wram.asm

-; Points to some data which somehow sets the music's speed
-wMusicSpeedPointer::
+; Points to some data which somehow sets the music's Velocity
+wMusicVelocityPointer::


This should stay to "speed" (it is music related, not entity-related)

kemenaran · 2023-12-31T21:33:49Z

tools/gfx/png.py

@@ -2139,15 +2139,15 @@ def asRGBA8(self):
        sample.  This method is similar to :meth:`asRGB8` and
        :meth:`asRGBA`:  The result pixels have an alpha channel, *and*
        values are rescaled to the range 0 to 255.  The alpha channel is
-        synthesized if necessary (with a small speed penalty).
+        synthesized if necessary (with a small Velocity penalty).


The replacement should not touch the scripts in tools/*

kemenaran · 2023-12-31T21:36:21Z

src/code/home/animated_tiles.asm


 AnimateSlowWaterfallTilesGroup::
    ld   h, HIGH(AnimatedTiles) + $0              ; $1C22: $26 $6A

-AnimateTilesSlowSpeed::
+AnimateTilesSlowVelocity::


Hmmm… This is not related to an entity, but to an animation speed. IMO it should remain AnimateTilesSlowSpeed.

kemenaran · 2023-12-31T21:36:40Z

src/code/home/animated_tiles.asm

@@ -374,7 +374,7 @@ AnimateTilesMediumSpeed::
 AnimateWaterCurrentsTilesGroup::
    ld   h, HIGH(AnimatedTiles) + $7              ; $1CD5: $26 $71

-AnimateTilesFastSpeed::
+AnimateTilesFastVelocity::


Same, it should remain AnimateTilesFastSpeed

kemenaran · 2023-12-31T21:37:08Z

src/code/home/init.asm

@@ -6,21 +6,21 @@
 ; is transfered to address $100, which immediatly jumps here.
 ; (See header.asm)
 Start::
-    ; Switch CPU to double-speed if needed
+    ; Switch CPU to double-Velocity if needed


CPU-speed is not entity-related: it should stay "speed"

kemenaran · 2023-12-31T21:37:18Z

src/code/home/init.asm


-.speedSwitchDone
+.VelocitySwitchDone


Here also, speed

kemenaran · 2023-12-31T21:38:27Z

src/code/audio_macros.asm

-; Takes a pointer to some data which determines the music speed.
-macro set_speed
+; Takes a pointer to some data which determines the music Velocity.
+macro set_Velocity


This is related to music, not entity code, and should remain "speed"

ealvesss · 2024-01-08T13:20:27Z

OMG a lot of I will change! 😄

I will fix the pointed files ASAP.

Cheers!

ealvesss added 2 commits December 29, 2023 18:02

fix: gitignore added vscode folder

2642d2a

fix: Rename Velocity to Speed zladx#369

a046ef3

ealvesss added 2 commits December 31, 2023 17:38

fix: added ignoring .idea (from clion IDE) folder

6c0100a

fix: renaming Speed -> Velocity

11efacf

ealvesss commented Dec 31, 2023

View reviewed changes

kemenaran reviewed Dec 31, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renamed Velocity to Speed Fix/#369 #561

Renamed Velocity to Speed Fix/#369 #561

ealvesss commented Dec 29, 2023

kemenaran commented Dec 31, 2023

ealvesss commented Dec 31, 2023

ealvesss commented Dec 31, 2023

ealvesss left a comment

ealvesss commented Dec 31, 2023

kemenaran left a comment

kemenaran Dec 31, 2023

kemenaran Dec 31, 2023

kemenaran Dec 31, 2023

kemenaran Dec 31, 2023

kemenaran Dec 31, 2023

kemenaran Dec 31, 2023

kemenaran Dec 31, 2023

kemenaran Dec 31, 2023

kemenaran Dec 31, 2023

kemenaran Dec 31, 2023

ealvesss commented Jan 8, 2024


		.speedSwitchDone
		.VelocitySwitchDone

Renamed Velocity to Speed Fix/#369 #561

Are you sure you want to change the base?

Renamed Velocity to Speed Fix/#369 #561

Conversation

ealvesss commented Dec 29, 2023

kemenaran commented Dec 31, 2023

ealvesss commented Dec 31, 2023

ealvesss commented Dec 31, 2023

ealvesss left a comment

Choose a reason for hiding this comment

ealvesss commented Dec 31, 2023

kemenaran left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ealvesss commented Jan 8, 2024