Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct writes to process.stderr #2454

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

pujal0909
Copy link
Contributor

@pujal0909 pujal0909 commented Mar 7, 2025

What It Does

When imperative initialization errors occur while in daemon mode, the errors now come back to the client terminal window.

https://github.com/zowe/imperative/blob/7571d180d54da03affe6e6e178a0617fc4d555f5/packages/imperative/src/plugins/utilities/NpmFunctions.ts#L45
https://github.com/zowe/imperative/blob/7571d180d54da03affe6e6e178a0617fc4d555f5/packages/imperative/src/plugins/utilities/npm-interface/uninstall.ts#L60
https://github.com/zowe/imperative/blob/7571d180d54da03affe6e6e178a0617fc4d555f5/packages/cmd/src/yargs/YargsConfigurer.ts#L87

#1875

How to Test

  1. With the current functionality, without daemon mode running, if you try to install a plugin that does not exist, it will display 404 errors.
  2. With the current functionality, with deamon mode running, if you try to install a plugin that does not exist, it will not display those errors.
  3. With the updated functionality, with daemon mode running, you will see the 404 errors appear.

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.51%. Comparing base (aa5c999) to head (68f7007).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...es/imperative/src/cmd/src/yargs/YargsConfigurer.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2454    +/-   ##
========================================
  Coverage   91.50%   91.51%            
========================================
  Files         641      641            
  Lines       18419    18433    +14     
  Branches     4001     3898   -103     
========================================
+ Hits        16855    16869    +14     
  Misses       1562     1562            
  Partials        2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Pujal <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
76.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@t1m0thyj t1m0thyj linked an issue Mar 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Remove direct writes to process.stderr
1 participant