Adding assets folder with new icons to WebHelpGenerator #2457
+34
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amber <[email protected]>
|
📅 Suggested merge-by date: 3/25/2025 |
Signed-off-by: Amber <[email protected]>
ATorrise
requested review from
anaxceron,
jace-roell,
t1m0thyj,
zFernand0,
awharn,
pujal0909 and
traeok
Signed-off-by: Amber Torrise <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2457 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 641 641
Lines 18425 18425
Branches 3965 3891 -74
=======================================
Hits 16861 16861
Misses 1562 1562
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anaxceron
reviewed
Mar 11, 2025
|
anaxceron
approved these changes
Mar 11, 2025
t1m0thyj
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Should we crop the SVG to have less whitespace and be square so that the Z doesn't look squished?
We did something similar for ZE and resized the PNG version of the image to be 256x256 - see zowe/zowe-explorer-vscode@9206c33.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Adds favicon to Zowe's Web Help.
How to Test
Run any command followed by the
--help-webflag.Review Checklist
I certify that I have:
Additional Comments
I've checked that this works in Chrome and Edge could use some testing help from those of you with different browsers to double check that this PR works as expected across the board.