feat: add submit uss across the board #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
|
dkelosky
approved these changes
Mar 6, 2025
traeok
reviewed
Mar 6, 2025
| result = jobs.SubmitUssResponse{ | ||
| Success: true, | ||
| Path: request.Path, | ||
| JobId: strings.TrimSpace(string(out)), |
There was a problem hiding this comment.
I think this is fine, but ideally we could use the output as-is from zowex 😋
|
|
||
| string only_jobid(result.get_option("--only-jobid")->get_value()); | ||
| if ("true" == only_jobid) | ||
| cout << jobid << endl; |
There was a problem hiding this comment.
Now that I'm reading the handler logic, can we remove the trim from the Go code since we don't print any spaces?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Added submit to the CLI plug-in 😋
How to Test
Deploy and run
zowe zssh submit ds|uss|lfNote: local-file (as well as stdin) depend on
submitJclwhich may not work until we fix:zowex job submit-jcl#183Review Checklist
I certify that I have:
Additional Comments
Again, just trying to complete the table 😋