Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: submit JCL from stdin #198

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: submit JCL from stdin #198

wants to merge 8 commits into from

Conversation

traeok
Copy link
Member

@traeok traeok commented Mar 11, 2025

What It Does

  • Implement Timothy's change in CLI plug-in for "submit JCL from stdin handler"
  • golang: Fix HandleSubmitJclRequest function to allow passing JCL encoding
  • c: Fix handle_job_submit_jcl function so it
    • converts input data from UTF-8 to given encoding before submitting JCL
    • accepts raw bytes from stdin when stdout isn't a TTY (scenario: user invokes zowex job submit-jcl in a shell)
  • c: Rename ZJB_UNKNWON_RC -> ZJB_UNKNOWN_RC and re-define constant as empty string (fixes bug in VSCE)

How to Test

Client:

  • Open a data set member in Zowe Explorer containing JCL
  • Right-click in the editor -> "Submit as JCL"
  • See the notification in the bottom-right? Click the "JOBXXXXX" hyperlink in the notification to reveal it in the Jobs tree.

zowex:

  • cat JCL_CONTENTS.txt | ./zowex job submit-jcl where JCL_CONTENTS.txt is:
//DONOTHING JOB (IZUACCT),'DONOTHING',CLASS=A,MSGCLASS=A,MSGLEVEL=(1,1),NOTIFY=&SYSUID

//STEP01 EXEC PGM=IEFBR14

//SYSPRINT DD SYSOUT=*
//SYSOUT DD SYSOUT=*
//SYSIN DD DUMMY

Review Checklist
I certify that I have:

Signed-off-by: Trae Yelovich <[email protected]>
@traeok traeok linked an issue Mar 11, 2025 that may be closed by this pull request
@traeok traeok marked this pull request as ready for review March 11, 2025 20:55
Signed-off-by: Trae Yelovich <[email protected]>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

job: Unable to zowex job submit-jcl
2 participants