Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass service param to use on force encoding. #205

Open
wants to merge 1 commit into
base: v1.x/staging
Choose a base branch
from

Conversation

Akayeshmantha
Copy link
Contributor

@Akayeshmantha Akayeshmantha commented Aug 5, 2020

Pass the service object to refer in common-c method

@ifakhrutdinov
Copy link
Contributor

@Akayeshmantha can you clarify the end goal of the change? That is, what are you trying to achieve?

@ifakhrutdinov ifakhrutdinov self-requested a review August 31, 2020 06:27
Copy link
Contributor

@ifakhrutdinov ifakhrutdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify the intent.

@Akayeshmantha
Copy link
Contributor Author

@ifakhrutdinov for the changes done in here zowe/zowe-common-c#160 in commons. We need to pass the service object from zss in order to capture the request params.

@ifakhrutdinov
Copy link
Contributor

The only place where the service parm is used in respondWithUnixFile2 is this

    if ((NULL != service) &&
        (NULL != service->customHeadersFunction))
    {
      service->customHeadersFunction(service, response);
    }

Can you point me to the place where you wanted to use it?

@1000TurquoisePogs
Copy link
Member

This needs a real description. Even if I know what it is right now, others don't and it's likely that a year from now if I need to review history, I won't remember.
I believe this is for the file transfer app feature where you may want to explicitly download as a particular encoding in the case that something is tagged incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants