-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unix file copy #376
Open
adrazilo
wants to merge
11
commits into
zowe:v1.x/staging
Choose a base branch
from
adrazilo:unixFileCopy
base: v1.x/staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Unix file copy #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
DivergentEuropeans
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, /copy endpoint looks good to me! 🍨 Tested forceOverwrite, newName attribs too, yield proper responses
TODOs make sense
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes the unixFileCopy command on the mock server so that it properly updates the global directory and returns a message response.
Type of change
PR Checklist
Testing
To test this feature, please consider the following test conditions:
Further comments
This is my first PR! It is also a great introductory task to working with the mock server.