API for Dataset/Dataset Member Allocation #473
Conversation
Signed-off-by: Aditya Ranshinge <[email protected]>
…Directory Blocks, Dataset Name Type attributes for dataset creation Signed-off-by: Aditya Ranshinge <[email protected]>
Signed-off-by: Aditya Ranshinge <[email protected]>
…issue Signed-off-by: Aditya Ranshinge <[email protected]>
|
I'll review this once the zowe-common-c PR has been figured out. |
Signed-off-by: Aditya Ranshinge <[email protected]>
…emoved unwanted functions and macros Signed-off-by: Aditya Ranshinge <[email protected]>
Signed-off-by: Aditya Ranshinge <[email protected]>
c/datasetjson.c
Outdated
| rc = setTextUnit(TEXT_UNIT_INT24, 0, NULL, toi, DALBLKLN, configsCount, inputTextUnit); | ||
| } | ||
| } | ||
| } else if(!strcmp(propString, "status")) { |
There was a problem hiding this comment.
this should be called disp, not status, because disp is the term that everyone knows.
c/datasetjson.c
Outdated
| } else if (!strcmp(propString, "ndisp")) { | ||
| if (!strcmp(valueString, "UNCATLG")){ | ||
| parmDefn = DISP_UNCATLG; | ||
| } else if (!strcmp(valueString, "DELETE")){ |
There was a problem hiding this comment.
if delete deletes... this shouldnt be in the PUT api at all.
There was a problem hiding this comment.
I will remove it from PUT api
| } | ||
| rc = setTextUnit(TEXT_UNIT_CHAR, 0, NULL, parmDefn, DALSTATS, configsCount, inputTextUnit); | ||
| } else if (!strcmp(propString, "ndisp")) { | ||
| if (!strcmp(valueString, "UNCATLG")){ |
There was a problem hiding this comment.
i'd like to know more about uncatalog to know if this is something we should be allowing the users to do.
There was a problem hiding this comment.
There is very limited IBM documentation about UNCATLG parameter.
Explanation of other parameters is present but links pointing to UNCATLG doesn't have contents like this link https://www.ibm.com/docs/en/zos/2.1.0?topic=parameter-uncataloging-data-set
But what I have got so far is "In UNCATLG case the data set exists but it deletes the catalog entry from the catalog file. "
|
I didn't mark this PR as bad or good but rather just saw some things that made me thing we should ask a senior mainframe user to get opinions on whether we should restrict the API to avoid people accidentally doing things they will regret due to having options they dont understand. |
| if (valueStrLen <= CLASS_WRITER_SIZE){ | ||
| rc = setTextUnit(TEXT_UNIT_STRING, valueStrLen, &(valueString)[0], 0, DALSPGNM, configsCount, inputTextUnit); | ||
| } | ||
| } else if(!strcmp(propString, "close")) { |
There was a problem hiding this comment.
meaning "autounallocate"
There was a problem hiding this comment.
we should have code comments linking over here because these are super confusing and we will forget what these mean.
https://www.ibm.com/docs/en/zos/2.1.0?topic=mvs-zos-programming-authorized-assembler-services-guide
https://www-40.ibm.com/servers/resourcelink/svc00100.nsf/pages/zOSV2R3sa231371/$file/ieaa800_v2r3.pdf
There was a problem hiding this comment.
Do you want me to add "autounallocate" comment here?
I have referred these docs https://www.ibm.com/docs/en/zos/2.4.0?topic=units-unallocation-close-specification-key-001c
c/datasetjson.c
Outdated
| if (valueStrLen <= DD_NAME_LEN){ | ||
| rc = setTextUnit(TEXT_UNIT_STRING, DD_NAME_LEN, &(valueString)[0], 0, DALRTDDN, configsCount, inputTextUnit); | ||
| } | ||
| } else if(!strcmp(propString, "spin")) { |
Signed-off-by: Aditya Ranshinge <[email protected]>
Proposed changes
API for Dataset/Dataset Member Allocation was implemented in #351 this PR , which was reviewed by Leonty.
This PR is continuation of above mentioned PR where Allocation Unit, Average Record Unit, Primary Space, Secondary Space, Directory Blocks, Dataset Name Type attributes added for dataset creation.
This pull request implements the following feature:
This PR depends upon the following PRs:
zowe/zowe-common-c#292
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments