-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:Rework and enable tests for Merels. #433 #852
base: main
Are you sure you want to change the base?
Conversation
Hello @avijitdas126, it seems like you have referenced #433 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage. Please run An example of a correctly-formatted commit:
To learn how to write a great commit message, please refer to our guide. |
9732e3a
to
6044cf7
Compare
@amanagr could you please review this PR? |
Hi @avijitdas126 thanks for working on this. Please read https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html |
Thanks @amanagr for the reference! I've gone through Zulip's commit discipline guidelines. I'll ensure my commits are structured as minimal, self-contained units, with proper formatting and clear commit messages. Let me know if there are any specific points you'd like me to focus on! |
This commit fixes and enables the test suite for the Merels bot by addressing import issues, updating test execution paths, and ensuring compatibility with the Zulip bot framework.
Added missing whitespace for better readability and fixed minor typos in help_message and alert_move_message. Improved assertions and refactored redundant checks for cleaner test logic.
Rework and enable tests for Merels. #433
Fixes: #433
This PR fixes and enables the test suite for the Merels bot by resolving import issues,
adjusting test execution paths, and ensuring compatibility with the Zulip bot framework.
Changes:
test_merels.py
zulip-run-bot
How did you test this PR?
pytest zulip_bots/bots/merels/
to verify all tests passSelf-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: