Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aws IP Ranges in routing #430

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

SGFGOV
Copy link

@SGFGOV SGFGOV commented Aug 13, 2022


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

includes additional routing options to aws services

@SGFGOV SGFGOV changed the title Aws ip ranges feature request: Aws ip ranges Aug 13, 2022
@SGFGOV SGFGOV changed the title feature request: Aws ip ranges feat (Aws ip ranges): use nat for accessing aws services Aug 13, 2022
@SGFGOV SGFGOV changed the title feat (Aws ip ranges): use nat for accessing aws services feat: aws IP Ranges in routing Aug 13, 2022
@SGFGOV
Copy link
Author

SGFGOV commented Aug 13, 2022

@zxkane ,

can you please approve the PR if all is well.

Copy link
Owner

@zxkane zxkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SGFGOV , thanks for your contribution. Few things need be polished before merging it.

@SGFGOV SGFGOV requested a review from zxkane August 30, 2022 08:03
Copy link
Author

@SGFGOV SGFGOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated files as requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants