Add flashprog flasher #92
Conversation
Signed-off-by: Eduard Kaverinskyi <[email protected]>
Signed-off-by: Eduard Kaverinskyi <[email protected]>
Signed-off-by: Eduard Kaverinskyi <[email protected]>
|
@tym2k1 This is ready for review. While tool builds, please pay attention to the configuration (For example, I disable CONFIG_JLINK_SPI=no). I am not sure if we may need this or not. |
Signed-off-by: Eduard Kaverinskyi <[email protected]>
|
P.S. Fixed pre-commit |
|
|
||
| PV = "1.0+${SRCPV}" | ||
| SRC_URI = "git://github.com/SourceArcade/flashprog.git;protocol=https;branch=main" | ||
| SRCREV = "eb2c04185f8f471c768b742d66e4c552effdd9cb" | ||
|
|
||
| EXTRA_OEMAKE = "NOSTRIP=1" | ||
| EXTRA_OEMAKE = "CONFIG_JLINK_SPI=no" |
There was a problem hiding this comment.
Is there a specific context or need for this?
There was a problem hiding this comment.
It requires libjaylink, and I am not sure what is the best way to add it, or if we need this option at all, so I added this flag just so everything works and we can work from there
There was a problem hiding this comment.
There will be missing functionality though and the utility won't be able to flash some devices. The syntacore/libjaylink doesn't seem that hard to port to Yocto. In case we decide to go with disabling support for JLINK appropriate comments should be added to this bb recipe so that the reasoning for this change can be easily found in the future.
There was a problem hiding this comment.
@macpijan how do you think we should proceed in this case?
There was a problem hiding this comment.
I am not aware of any need for JLINK right now. So this is fine for us. We can leave link from @tym2k1 as a comment to this line.
Signed-off-by: Eduard Kaverinskyi <[email protected]>
|
|
||
| PV = "1.0+${SRCPV}" | ||
| SRC_URI = "git://github.com/SourceArcade/flashprog.git;protocol=https;branch=main" | ||
| SRCREV = "eb2c04185f8f471c768b742d66e4c552effdd9cb" |
There was a problem hiding this comment.
We should use a commit that corresponds to the tag we specify. In this case it'd be v1.3. It also ensures we're using a working version not development commits in between releases
There was a problem hiding this comment.
Added in latest commits. We now build from the v1.3 tag
Signed-off-by: Eduard Kaverinskyi <[email protected]>
Signed-off-by: Eduard Kaverinskyi <[email protected]>
This reverts commit 7aa7f16.
Signed-off-by: Eduard Kaverinskyi <[email protected]>
Solves #77. (Adds https://github.com/SourceArcade/flashprog)