-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flashprog flasher #92
Open
EduKav1813
wants to merge
9
commits into
develop
Choose a base branch
from
add-flashprog-flasher
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
36b5123
recipes-devtools/: Add flashprog recipe
EduKav1813 a025580
recipes-extended/: add flashprog-flasher to packagegroup
EduKav1813 996c6c6
flashprog-flasher.bb: resolve dependencies and parameters
EduKav1813 4ca0325
flashprog-flasher_1.3.bb : fix filename (pre-commit)
EduKav1813 a6b93cd
flashprog-flasher_1.3.bb: Add reasoning behind disabled jlink
EduKav1813 e305a46
flashprog-flasher.bb: change revision to v1.3
EduKav1813 7aa7f16
flashprog-flasher.bb: fix fetching by tag
EduKav1813 30215ce
Revert "flashprog-flasher.bb: fix fetching by tag"
EduKav1813 1f89079
flashprog-flasher.bb: change branch to 1.3.x
EduKav1813 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific context or need for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It requires libjaylink, and I am not sure what is the best way to add it, or if we need this option at all, so I added this flag just so everything works and we can work from there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be missing functionality though and the utility won't be able to flash some devices. The syntacore/libjaylink doesn't seem that hard to port to Yocto. In case we decide to go with disabling support for JLINK appropriate comments should be added to this bb recipe so that the reasoning for this change can be easily found in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@macpijan how do you think we should proceed in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not aware of any need for JLINK right now. So this is fine for us. We can leave link from @tym2k1 as a comment to this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment: a6b93cd