osfv integration #30
Merged
osfv integration #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLangowski
force-pushed
the
osfv-integration
branch
2 times, most recently
from
cc6f8a0 to
3316169
Compare
PLangowski
force-pushed
the
osfv-integration
branch
2 times, most recently
from
623e8ff to
226b006
Compare
macpijan
requested changes
Apr 18, 2024
PLangowski
force-pushed
the
osfv-integration
branch
6 times, most recently
from
2cb1983 to
f9c6bd5
Compare
macpijan
reviewed
Apr 24, 2024
There was a problem hiding this comment.
@PLangowski Code looks OK, but we still need to:
- cleanup commits - we specifically do not want to merge commits like
wip, orrefactor, if possible; we should split the whole changes into a few logical commits - pre-commit fails, possibly you do not have it installed locally in this repo?
PLangowski
force-pushed
the
osfv-integration
branch
3 times, most recently
from
0eae6ba to
5c372ec
Compare
|
@macpijan I cleaned up the commits. |
macpijan
force-pushed
the
osfv-integration
branch
from
5c372ec to
3c2837f
Compare
Closed
Signed-off-by: Maciej Pijanowski <[email protected]>
Signed-off-by: Pawel Langowski <[email protected]>
Signed-off-by: Pawel Langowski <[email protected]>
Signed-off-by: Pawel Langowski <[email protected]>
Signed-off-by: Maciej Pijanowski <[email protected]>
macpijan
force-pushed
the
osfv-integration
branch
from
ed8aaa7 to
5bb4812
Compare
Signed-off-by: Maciej Pijanowski <[email protected]>
Signed-off-by: Maciej Pijanowski <[email protected]>
macpijan
force-pushed
the
osfv-integration
branch
from
4371d76 to
5747856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.