Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update tests for ExonGenomicCoordsMapper #364

Closed
wants to merge 7 commits into from
Closed

test: update tests for ExonGenomicCoordsMapper #364

wants to merge 7 commits into from

Conversation

korikuzma
Copy link
Member

  • remove unnecessary tests
  • add more edge cases
  • create tests for private methods

@korikuzma
refactor!: rename ExonCoord to _ExonCoord to indicate internal use
7d1e26b
@korikuzma
refactor: reorder classes and methods in exon_genomic_coords module
1539ccc 
addresses #224

* No code was changed in the classes or methods
@korikuzma
refactor: rename is_start kwarg in private methods to is_seg_start
b9d80fc 
addresses #224
@korikuzma
refactor: flatten tuple in _get_alt_ac_start_and_end output
24615fd 
* Also removed unnecessary mismatch checks. The way that exon coordinates are passed, there will never be a case where there would be a mismatch. Updated docstring accordingly with this assumption.
@korikuzma
store progress
b647d87
@korikuzma
Merge branch 'main' into tests
d17ff46
@korikuzma
add tests
e1778f9
@korikuzma korikuzma added priority:low Low priority test Changes to test code only labels Aug 26, 2024
@korikuzma korikuzma self-assigned this Aug 26, 2024
@jsstevenson
Copy link
Member

create tests for private methods

is this necessary? ostensibly the only behavior that matters is what's public -- is there something that our public method tests aren't capturing? I worry about creating redundant tests that we then have to do twice the work to maintain in the future

@korikuzma
Copy link
Member Author

create tests for private methods

is this necessary? ostensibly the only behavior that matters is what's public -- is there something that our public method tests aren't capturing? I worry about creating redundant tests that we then have to do twice the work to maintain in the future

@jsstevenson There are definitely pros/cons to testing private methods. This was a good exercise for me to better understand the codebase, think of edge cases, and see if private methods needed to be changed. I can change to only test public methods!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

This PR is stale because it has been open 7 day(s) with no activity. Please review this PR.

@github-actions github-actions bot added the stale label Sep 3, 2024
@korikuzma korikuzma removed the stale label Sep 3, 2024
@korikuzma korikuzma removed the request for review from jarbesfeld September 3, 2024 14:27
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 7 day(s) with no activity. Please review this PR.

@github-actions github-actions bot added the stale label Sep 11, 2024
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 7 day(s) with no activity. Please review this PR.

@github-actions github-actions bot added the stale label Sep 24, 2024
@korikuzma
Copy link
Member Author

Closing for now until I can come back to this

@korikuzma korikuzma closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@korikuzma korikuzma

Labels
priority:low Low priority stale stale-exempt test Changes to test code only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korikuzma @jsstevenson