Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing-on-gke part 3] Support instance-id and more complex configuration combinations (reopen of PR#2319) #2359

Merged

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Aug 19, 2024

Description

Enhancements to testing on GKE (reopen of accidentally closed #2319)

  • Support instance_id
    1. Support env variable instance_id in run-script and in the python scripts (this allows multiple users to run the same tests using the same input/output bucket(s) without overwriting each others's outputs).
  • Support multiple combinations of blockSize,numThreads,filesPerThread combinations for a given fileSize for fio tests, in the same run without overwriting each other.

This follows right after #2272 .

This is followed up in #2329 .

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (54fd63e) to head (066952e).

Additional details and impacted files
@@                                 Coverage Diff                                 @@
##           garnitin/add-gke-load-testing/add-run-script/v1    #2359      +/-   ##
===================================================================================
- Coverage                                            79.12%   79.10%   -0.02%     
===================================================================================
  Files                                                  105      105              
  Lines                                                11577    11577              
===================================================================================
- Hits                                                  9160     9158       -2     
- Misses                                                1954     1956       +2     
  Partials                                               463      463              
Flag Coverage Δ
unittests 79.10% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 3] Support instance-id and more complex configuration combinations [testing-on-gke part 3] Support instance-id and more complex configuration combinations (reopen of PR#2319) Aug 19, 2024
@gargnitingoogle gargnitingoogle marked this pull request as ready for review August 19, 2024 07:21
@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners August 19, 2024 07:21
@gargnitingoogle gargnitingoogle requested review from raj-prince, kislaykishore and a team and removed request for a team August 19, 2024 07:21
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 6fd5de1 to 4eeb25c Compare August 19, 2024 09:00
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from e35a174 to bc506bc Compare August 19, 2024 09:00
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 4eeb25c to 14d311e Compare August 19, 2024 15:14
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from bc506bc to 1dc79a2 Compare August 19, 2024 15:15
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch 2 times, most recently from 87babfb to 4d3d298 Compare August 20, 2024 05:36
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from 1dc79a2 to 120e393 Compare August 20, 2024 05:42
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 4d3d298 to 25d6251 Compare August 21, 2024 07:35
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from 120e393 to 80efd26 Compare August 21, 2024 07:35
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 25d6251 to 54fd63e Compare August 21, 2024 11:52
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from 80efd26 to 066952e Compare August 21, 2024 11:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 54fd63e to 8b97e1c Compare August 22, 2024 10:23
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from 066952e to 2b68010 Compare August 22, 2024 10:23
- Support instance_id (unique-id for the current test-run, allowed
  multiple runs concurrently)
   1. Support env variable instance_id in run-script.
   2. Support instance_id as argument in fio/dlio
      run_tests.py, parse_logs.py
   3. Pass instance_id in fio/dlio pod yaml config
- Support multiple combinations of blockSize,numThreads,
  filesPerThread, combinations for a given fileSize for fio tests.
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from 2b68010 to 6e314a3 Compare August 22, 2024 12:53
@gargnitingoogle gargnitingoogle changed the base branch from garnitin/add-gke-load-testing/add-run-script/v1 to master August 22, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants