-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testing-on-gke part 3] Support instance-id and more complex configuration combinations (reopen of PR#2319) #2359
Merged
gargnitingoogle
merged 2 commits into
master
from
garnitin/add-gke-load-testing/support-special-cases/v1
Aug 26, 2024
Merged
[testing-on-gke part 3] Support instance-id and more complex configuration combinations (reopen of PR#2319) #2359
gargnitingoogle
merged 2 commits into
master
from
garnitin/add-gke-load-testing/support-special-cases/v1
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## garnitin/add-gke-load-testing/add-run-script/v1 #2359 +/- ##
===================================================================================
- Coverage 79.12% 79.10% -0.02%
===================================================================================
Files 105 105
Lines 11577 11577
===================================================================================
- Hits 9160 9158 -2
- Misses 1954 1956 +2
Partials 463 463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Aug 19, 2024
gargnitingoogle
changed the title
[testing-on-gke part 3] Support instance-id and more complex configuration combinations
[testing-on-gke part 3] Support instance-id and more complex configuration combinations (reopen of PR#2319)
Aug 19, 2024
gargnitingoogle
requested review from
raj-prince,
kislaykishore and
a team
and removed request for
a team
August 19, 2024 07:21
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-run-script/v1
branch
from
August 19, 2024 09:00
6fd5de1
to
4eeb25c
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/support-special-cases/v1
branch
from
August 19, 2024 09:00
e35a174
to
bc506bc
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-run-script/v1
branch
from
August 19, 2024 15:14
4eeb25c
to
14d311e
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/support-special-cases/v1
branch
from
August 19, 2024 15:15
bc506bc
to
1dc79a2
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-run-script/v1
branch
2 times, most recently
from
August 20, 2024 05:36
87babfb
to
4d3d298
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/support-special-cases/v1
branch
from
August 20, 2024 05:42
1dc79a2
to
120e393
Compare
perfmetrics/scripts/testing_on_gke/examples/dlio/unet3d-loading-test/templates/dlio-tester.yaml
Show resolved
Hide resolved
perfmetrics/scripts/testing_on_gke/examples/fio/loading-test/templates/fio-tester.yaml
Show resolved
Hide resolved
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-run-script/v1
branch
from
August 21, 2024 07:35
4d3d298
to
25d6251
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/support-special-cases/v1
branch
from
August 21, 2024 07:35
120e393
to
80efd26
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-run-script/v1
branch
from
August 21, 2024 11:52
25d6251
to
54fd63e
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/support-special-cases/v1
branch
from
August 21, 2024 11:53
80efd26
to
066952e
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-run-script/v1
branch
from
August 22, 2024 10:23
54fd63e
to
8b97e1c
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/support-special-cases/v1
branch
from
August 22, 2024 10:23
066952e
to
2b68010
Compare
- Support instance_id (unique-id for the current test-run, allowed multiple runs concurrently) 1. Support env variable instance_id in run-script. 2. Support instance_id as argument in fio/dlio run_tests.py, parse_logs.py 3. Pass instance_id in fio/dlio pod yaml config - Support multiple combinations of blockSize,numThreads, filesPerThread, combinations for a given fileSize for fio tests.
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/support-special-cases/v1
branch
from
August 22, 2024 12:53
2b68010
to
6e314a3
Compare
gargnitingoogle
changed the base branch from
garnitin/add-gke-load-testing/add-run-script/v1
to
master
August 22, 2024 13:22
kislaykishore
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhancements to testing on GKE (reopen of accidentally closed #2319)
This follows right after #2272 .
This is followed up in #2329 .
Link to the issue in case of a bug fix.
NA
Testing details