[testing-on-gke part 6.3] Use monitoring api for gce vm #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gargnitingoogle
commented
Sep 17, 2024
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/extract-common-runner-code
branch
from
05586ea
to
982f22a
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
bf2eac8
to
858df9d
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/extract-common-runner-code
branch
from
982f22a
to
a52219a
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
e9904e0
to
1203353
Compare
gargnitingoogle
requested review from
ankitaluthra1
and removed request for
a team
gargnitingoogle
commented
Sep 17, 2024
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/extract-common-runner-code
branch
from
a52219a
to
e1731fd
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
1203353
to
fc374e8
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/extract-common-runner-code
branch
from
e1731fd
to
b84c83c
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
fc374e8
to
b8b5c7f
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/extract-common-runner-code
branch
from
b84c83c
to
5e71087
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
b8b5c7f
to
5e20671
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/extract-common-runner-code
branch
from
5e71087
to
fda10f6
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
5e20671
to
e94975f
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/extract-common-runner-code
branch
from
fda10f6
to
7bb66ac
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
e94975f
to
254c03c
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/extract-common-runner-code
branch
from
7bb66ac
to
9063eaa
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
254c03c
to
5d3e38d
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/extract-common-runner-code
branch
from
9063eaa
to
6f2c2f6
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
5d3e38d
to
55d10d9
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
4e0d52c
to
4fac67a
Compare
gargnitingoogle
changed the base branch from
garnitin/add-gke-load-testing/extract-common-runner-code
to
master
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
4fac67a
to
547f5bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2495 +/- ##
==========================================
+ Coverage 78.32% 78.35% +0.02%
==========================================
Files 107 107
Lines 11776 11776
==========================================
+ Hits 9224 9227 +3
+ Misses 2068 2066 -2
+ Partials 484 483 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
4 times, most recently
from
0e9c9d9
to
2f62229
Compare
perfmetrics/scripts/testing_on_gke/examples/utils/utils_test.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/testing_on_gke/examples/utils/utils_test.py
Outdated
Show resolved
Hide resolved
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
2f62229
to
d5fc7d6
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
2 times, most recently
from
91bd178
to
7ddf503
Compare
kislaykishore
approved these changes
Sep 27, 2024
mash can't be instaled on gce VMs, so instead using monitoring API on it, for getting VM metrics (cpu/memory usage).
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
from
7ddf503
to
edff586
Compare
gargnitingoogle
deleted the
garnitin/add-gke-load-testing/monitoring-api-for-gce-vm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The backend library uses mash (monarch cli frontend) to access VM metrics on a cloudtop, but mash can't be installed on a GCE VM, so as an alternative, using monarch monitoring API to access the same VM metrics.
This is on top of #2493 and is followed up in #2482 .
Link to the issue in case of a bug fix.
NA
Testing details