Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing-on-gke part 6.4] Add support for GCE VM #2482

Merged

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Sep 16, 2024

Description

Handle dependencies for successful execution on a GCE VM.

  • Install google-cloud-monitoring python package
  • Wait 30 min after CSI driver installation, before deploying pods, to avoid failure
  • Avoid putting google in the name of the package-bucket as google is not allowed in bucket names.

This is on top of #2495 and is followed up in #2496 .

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle changed the title Add support for GCE VM [testing-on-gke part 6] Add support for GCE VM Sep 16, 2024
@gargnitingoogle gargnitingoogle marked this pull request as ready for review September 16, 2024 09:03
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 5bf22e2 to 1243c45 Compare September 16, 2024 10:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from c8a2572 to aed8638 Compare September 17, 2024 07:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 1243c45 to 1b3cb96 Compare September 17, 2024 07:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from aed8638 to 824cf7b Compare September 18, 2024 06:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch 3 times, most recently from eecce33 to 8484f07 Compare September 18, 2024 08:17
@gargnitingoogle gargnitingoogle changed the base branch from garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 to master September 18, 2024 08:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 8484f07 to e3b6ec6 Compare September 18, 2024 08:27
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.33%. Comparing base (459a6b8) to head (4d15967).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2482      +/-   ##
==========================================
- Coverage   78.35%   78.33%   -0.02%     
==========================================
  Files         107      107              
  Lines       11776    11776              
==========================================
- Hits         9227     9225       -2     
- Misses       2066     2068       +2     
  Partials      483      483              
Flag Coverage Δ
unittests 78.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from e3b6ec6 to 41bb04c Compare September 18, 2024 08:41
@gargnitingoogle gargnitingoogle changed the base branch from master to garnitin/add-gke-load-testing/monitoring-api-for-gce-vm September 18, 2024 08:47
@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 6] Add support for GCE VM [testing-on-gke part 6.4] Add support for GCE VM Sep 18, 2024
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from 254c03c to 5d3e38d Compare September 18, 2024 08:55
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 41bb04c to fb7d0f1 Compare September 18, 2024 08:55
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from 5d3e38d to 55d10d9 Compare September 18, 2024 17:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from fb7d0f1 to 43b5572 Compare September 18, 2024 17:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 576962f to 4015b37 Compare September 24, 2024 05:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch 2 times, most recently from 547f5bc to cb60045 Compare September 24, 2024 12:03
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 4015b37 to c227f0e Compare September 24, 2024 12:03
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from cb60045 to b3147b5 Compare September 25, 2024 07:21
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from c227f0e to 94a2884 Compare September 25, 2024 07:21
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from b3147b5 to 0e9c9d9 Compare September 25, 2024 12:33
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 94a2884 to 142283d Compare September 25, 2024 12:33
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from 0e9c9d9 to 2f62229 Compare September 25, 2024 13:45
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 142283d to f1ea7d3 Compare September 25, 2024 13:45
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from 2f62229 to d5fc7d6 Compare September 27, 2024 04:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch 2 times, most recently from c7ea93e to a951192 Compare September 27, 2024 06:12
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from 0da081a to f584e0f Compare September 27, 2024 07:52
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch 2 times, most recently from ec97a13 to 545996a Compare September 27, 2024 09:31
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from 91bd178 to 7ddf503 Compare September 27, 2024 09:44
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 545996a to f1ab9e0 Compare September 27, 2024 09:44
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from 7ddf503 to edff586 Compare September 27, 2024 12:45
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from f1ab9e0 to 1849983 Compare September 27, 2024 12:45
@gargnitingoogle gargnitingoogle changed the base branch from garnitin/add-gke-load-testing/monitoring-api-for-gce-vm to master September 27, 2024 13:35
@gargnitingoogle gargnitingoogle dismissed charith87’s stale review September 27, 2024 13:35

The base branch was changed.

Don't create package bucket with google in name
ignore FileNotFoundError for mash not installed
fix gce vm gcloud installation
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 1849983 to 4d15967 Compare September 27, 2024 13:37
@gargnitingoogle gargnitingoogle merged commit 9ccfd34 into master Sep 27, 2024
12 checks passed
@gargnitingoogle gargnitingoogle deleted the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch September 27, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants