Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Agnostic with Adaptive in FrankWolfe tests #116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace Agnostic with Adaptive in FrankWolfe tests #116

wants to merge 2 commits into from

Conversation

BatyLeo
Copy link
Member

@BatyLeo BatyLeo commented Jun 24, 2024 •
edited
Loading

The issue ZIB-IOL/FrankWolfe.jl#387 with Adaptive line search seems fixed now.

Keywork option relaxed_smoothness=true seems not needed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

@BatyLeo BatyLeo requested a review from gdalle June 24, 2024 09:35
@BatyLeo BatyLeo mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdalle gdalle Awaiting requested review from gdalle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BatyLeo @codecov-commenter